Document Hybird Overlay Config #513

pecameron · 2020-03-04T20:16:14Z

How to configure a hybird cluster of Linux an Windows nodes.

https://issues.redhat.com/browse/SDN-842

Signed-off-by: Phil Cameron pcameron@redhat.com

pecameron · 2020-03-04T20:19:45Z

sebsoto

Thanks @pecameron this is really helpful! I'll give it a shot, in the meantime theres a few spelling changes that could be made

README.md

sebsoto · 2020-03-04T21:41:22Z

Followed the instructions and it seemed to work:

INFO Waiting up to 30m0s for the cluster at https://api.ssoto-dev.devcluster.openshift.com:6443 to initialize... 
INFO Waiting up to 10m0s for the openshift-console route to be created... 
INFO Install complete!                            
INFO To access the cluster as the system:admin user when using 'oc', run 'export KUBECONFIG=/home/ssoto/dev/openshift/installer/aws/aws_3_4_20/auth/kubeconfig' 
INFO Access the OpenShift web-console here: https://console-openshift-console.apps.ssoto-dev.devcluster.openshift.com 
INFO Login to the console with user: kubeadmin, password:  REDACTED
[ssoto@localhost aws]$ export KUBECONFIG=/home/ssoto/dev/openshift/installer/aws/aws_3_4_20/auth/kubeconfig
[ssoto@localhost aws]$ oc get -o yaml network.operator cluster
apiVersion: operator.openshift.io/v1
kind: Network
metadata:
  creationTimestamp: "2020-03-04T21:04:35Z"
  generation: 1
  name: cluster
  resourceVersion: "441"
  selfLink: /apis/operator.openshift.io/v1/networks/cluster
  uid: 192e1799-670e-4c3d-b795-c09fa91cf503
spec:
  clusterNetwork:
  - cidr: 10.128.0.0/14
    hostPrefix: 23
  defaultNetwork:
    ovnKubernetesConfig:
      hybridOverlayConfig:
        hybridClusterNetwork:
        - cidr: 10.132.0.0/14
          hostPrefix: 23
    type: OVNKubernetes
  serviceNetwork:
  - 172.30.0.0/16
status: {}

dcbw · 2020-03-04T22:05:21Z

README.md

+        - cidr: 10.132.0.0/14
+          hostPrefix: 23
+```
+The hybridClusterNetwork cidr and hostPrefix are used when adding windows nodes. This cidr must not overlap the ClusterNetwork cidr.


@pecameron windows -> Windows?

Put the first cidr here in backticks to show it's a literal. Capitalize the second I think because it's a generic reference.

@dcbw Did I get the changes right?
Also, found that we are limited to a single hybridClusterNetwork: cidr.
Question: did we change from config.openshift.io/v1 to operator.openshift.io/v1? If so installer is wrong.

@pecameron we shouldn't be limited to a single hybrid overlay CIDR. For the YAML I think it would be:

ovnKubernetesConfig: hybridOverlayConfig: hybridClusterNetwork: - cidr: 10.132.0.0/14 hostPrefix: 23 - cidr: 11.150.0.0/14 hostPrefix: 23

@dcbw The code does 1 CIDR.
pkg/network/ovn_kubernetes.go:82: data.Data["OVNHybridOverlayNetCIDR"] = c.HybridOverlayConfig.HybridClusterNetwork[0].CIDR

@pecameron I guess we should fix that in CNO then... @JacobTanenbaum can you take that task?

pecameron · 2020-03-04T22:06:35Z

@sebsoto Thanks for giving it a try. I may your suggested changes. PTAL
@dcbw PTAL
Since this is a README change the failed tests are flakes
/retest

pecameron · 2020-03-05T14:17:10Z

@dcbw The only change is the README.md file. Test failures are not related to these changes.
This can be merged when the changes are approved.

aravindhp · 2020-03-05T14:27:20Z

@dcbw The only change is the README.md file. Test failures are not related to these changes.
This can be merged when the changes are approved.

@dcbw FYI, I have been using /override <testname> to override tests for doc changes.

README.md

How to configure a hybrid cluster of Linux an Windows nodes. SDN-842 - Bring up hybrid cluster and document process https://issues.redhat.com/browse/SDN-842 Signed-off-by: Phil Cameron <pcameron@redhat.com>

pecameron · 2020-03-05T21:36:28Z

@dcbw PTAL

pecameron · 2020-03-06T14:29:58Z

@dcbw @sebsoto @aravindhp PTAL

knobunc · 2020-03-06T15:10:51Z

/lgtm
/approve

knobunc · 2020-03-06T15:10:59Z

/retest

openshift-ci-robot · 2020-03-06T15:16:09Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knobunc, pecameron

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [knobunc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2020-03-06T17:04:45Z

/retest

Please review the full test history for this PR and help us cut down flakes.

pecameron · 2020-03-06T17:44:05Z

On 3/6/20 10:45 AM, Dan Williams wrote: ***@***.**** commented on this pull request. ------------------------------------------------------------------------ In README.md <#513 (comment)>: > +``` +Edit the new file as follows: +- change first line `apiVersion: config.openshift.io/v1` to `apiVersion: operator.openshift.io/v1` +- Add the following to the `spec:` section + +```yaml +spec: + defaultNetwork: + type: OVNKubernetes + ovnKubernetesConfig: + hybridOverlayConfig: + hybridClusterNetwork: + - cidr: 10.132.0.0/14 + hostPrefix: 23 +``` +The hybridClusterNetwork cidr and hostPrefix are used when adding windows nodes. This cidr must not overlap the ClusterNetwork cidr. @pecameron <https://github.com/pecameron> I guess we should fix that in CNO then... @JacobTanenbaum <https://github.com/JacobTanenbaum> can you take that task?

Actually, shouldn't this be in the configmap rather than the command line? Does ovnkube support a vector of CIRDs?

…

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#513?email_source=notifications&email_token=ADKSA6QGTYIY3JPSVQOMLN3RGEK77A5CNFSM4LBSMZFKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCYKC2EQ#discussion_r388978586>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADKSA6XQAWFS5IIRHFDY3ZLRGEK77ANCNFSM4LBSMZFA>.

openshift-bot · 2020-03-06T18:36:47Z

/retest

Please review the full test history for this PR and help us cut down flakes.

pecameron · 2020-03-06T18:55:23Z

/retest

openshift-bot · 2020-03-06T19:01:59Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-03-06T19:28:00Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2020-03-06T20:50:21Z

@pecameron: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-gcp-ovn	`37a778c`	link	`/test e2e-gcp-ovn`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 4, 2020

openshift-ci-robot requested review from danwinship and rcarrillocruz March 4, 2020 20:17

sebsoto suggested changes Mar 4, 2020

View reviewed changes

README.md Outdated Show resolved Hide resolved

README.md Outdated Show resolved Hide resolved

pecameron force-pushed the testhybird branch from 21332f4 to 9ecc181 Compare March 4, 2020 21:06

dcbw reviewed Mar 4, 2020

View reviewed changes

pecameron force-pushed the testhybird branch from 9ecc181 to 9731feb Compare March 5, 2020 14:19

pecameron force-pushed the testhybird branch 2 times, most recently from d7e98c9 to 8e6b600 Compare March 5, 2020 15:04

dcbw reviewed Mar 5, 2020

View reviewed changes

README.md Outdated Show resolved Hide resolved

dcbw reviewed Mar 5, 2020

View reviewed changes

README.md Outdated Show resolved Hide resolved

pecameron force-pushed the testhybird branch from 8e6b600 to 80984b0 Compare March 5, 2020 21:34

Document Hybrid Overlay Config

37a778c

How to configure a hybrid cluster of Linux an Windows nodes. SDN-842 - Bring up hybrid cluster and document process https://issues.redhat.com/browse/SDN-842 Signed-off-by: Phil Cameron <pcameron@redhat.com>

pecameron force-pushed the testhybird branch from 80984b0 to 37a778c Compare March 5, 2020 21:35

openshift-ci-robot assigned knobunc Mar 6, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 6, 2020

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 6, 2020

openshift-merge-robot merged commit 2ee6eea into openshift:master Mar 6, 2020

pecameron deleted the testhybird branch March 9, 2020 15:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Document Hybird Overlay Config #513

Document Hybird Overlay Config #513

pecameron commented Mar 4, 2020 •

edited

pecameron commented Mar 4, 2020

sebsoto left a comment

sebsoto commented Mar 4, 2020

dcbw Mar 4, 2020

dcbw Mar 4, 2020

pecameron Mar 5, 2020

dcbw Mar 5, 2020

pecameron Mar 5, 2020

dcbw Mar 6, 2020

pecameron commented Mar 4, 2020

pecameron commented Mar 5, 2020

aravindhp commented Mar 5, 2020

pecameron commented Mar 5, 2020

pecameron commented Mar 6, 2020

knobunc commented Mar 6, 2020

knobunc commented Mar 6, 2020

openshift-ci-robot commented Mar 6, 2020

openshift-bot commented Mar 6, 2020

pecameron commented Mar 6, 2020 via email

openshift-bot commented Mar 6, 2020

pecameron commented Mar 6, 2020

openshift-bot commented Mar 6, 2020

openshift-bot commented Mar 6, 2020

openshift-ci-robot commented Mar 6, 2020

Document Hybird Overlay Config #513

Document Hybird Overlay Config #513

Conversation

pecameron commented Mar 4, 2020 • edited

pecameron commented Mar 4, 2020

sebsoto left a comment

Choose a reason for hiding this comment

sebsoto commented Mar 4, 2020

dcbw Mar 4, 2020

Choose a reason for hiding this comment

dcbw Mar 4, 2020

Choose a reason for hiding this comment

pecameron Mar 5, 2020

Choose a reason for hiding this comment

dcbw Mar 5, 2020

Choose a reason for hiding this comment

pecameron Mar 5, 2020

Choose a reason for hiding this comment

dcbw Mar 6, 2020

Choose a reason for hiding this comment

pecameron commented Mar 4, 2020

pecameron commented Mar 5, 2020

aravindhp commented Mar 5, 2020

pecameron commented Mar 5, 2020

pecameron commented Mar 6, 2020

knobunc commented Mar 6, 2020

knobunc commented Mar 6, 2020

openshift-ci-robot commented Mar 6, 2020

openshift-bot commented Mar 6, 2020

pecameron commented Mar 6, 2020 via email

openshift-bot commented Mar 6, 2020

pecameron commented Mar 6, 2020

openshift-bot commented Mar 6, 2020

openshift-bot commented Mar 6, 2020

openshift-ci-robot commented Mar 6, 2020

pecameron commented Mar 4, 2020 •

edited