Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1812678: RBAC for Whereabouts should reference ippools.whereabouts.cni.cncf.io [backport 4.4.z] #528

Merged
merged 1 commit into from Apr 15, 2020
Merged

Bug 1812678: RBAC for Whereabouts should reference ippools.whereabouts.cni.cncf.io [backport 4.4.z] #528

merged 1 commit into from Apr 15, 2020

Conversation

dougbtv
Copy link
Member

@dougbtv dougbtv commented Mar 11, 2020

It was incorrectly set to ippools.whereabouts.cni.k8s.io and missed when it was
changed upstream/downstream for whereabouts.

Backport of #527

@dougbtv
RBAC for Whereabouts should reference ippools.whereabouts.cni.cncf.io
920474b 
It was incorrectly set to ippools.whereabouts.cni.k8s.io and missed when it was
changed upstream/downstream for whereabouts.
@openshift-ci-robot
Copy link
Contributor

@dougbtv: This pull request references Bugzilla bug 1812678, which is invalid:

  • expected the bug to target the "4.4.0" release, but it targets "4.4.z" instead
  • expected dependent Bugzilla bug 1812680 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ASSIGNED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1812678: RBAC for Whereabouts should reference ippools.whereabouts.cni.cncf.io [backport 4.4.z]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 11, 2020
@dougbtv
Copy link
Member Author

dougbtv commented Mar 11, 2020

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@dougbtv: This pull request references Bugzilla bug 1812678, which is invalid:

  • expected dependent Bugzilla bug 1812680 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ASSIGNED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abhat
Copy link
Contributor

abhat commented Mar 12, 2020

/retest
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 12, 2020
@dougbtv
Copy link
Member Author

dougbtv commented Mar 30, 2020

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@dougbtv: This pull request references Bugzilla bug 1812678, which is invalid:

  • expected the bug to target the "4.4.0" release, but it targets "4.4.z" instead
  • expected dependent Bugzilla bug 1812680 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ASSIGNED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dougbtv
Copy link
Member Author

dougbtv commented Mar 30, 2020

/test e2e-gcp-upgrade

1 similar comment
@dougbtv
Copy link
Member Author

dougbtv commented Mar 31, 2020

/test e2e-gcp-upgrade

@dougbtv
Copy link
Member Author

dougbtv commented Mar 31, 2020

/test e2e-gcp-upgra

@dougbtv
Copy link
Member Author

dougbtv commented Mar 31, 2020

/test e2e-gcp-upgrade

2 similar comments
@dougbtv
Copy link
Member Author

dougbtv commented Mar 31, 2020

/test e2e-gcp-upgrade

@dougbtv
Copy link
Member Author

dougbtv commented Apr 1, 2020

/test e2e-gcp-upgrade

@dougbtv
Copy link
Member Author

dougbtv commented Apr 1, 2020

/test e2e-gcp-upgrade

API server flakes, looks like to me.

@dougbtv
Copy link
Member Author

dougbtv commented Apr 1, 2020

/test e2e-gcp-upgrade

3 similar comments
@dougbtv
Copy link
Member Author

dougbtv commented Apr 2, 2020

/test e2e-gcp-upgrade

@dougbtv
Copy link
Member Author

dougbtv commented Apr 2, 2020

/test e2e-gcp-upgrade

@dougbtv
Copy link
Member Author

dougbtv commented Apr 3, 2020

/test e2e-gcp-upgrade

@abhat
Copy link
Contributor

abhat commented Apr 3, 2020

/lgtm

1 similar comment
@abhat
Copy link
Contributor

abhat commented Apr 6, 2020

/lgtm

@knobunc
Copy link
Contributor

knobunc commented Apr 6, 2020

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhat, dougbtv, knobunc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 6, 2020
@dougbtv
Copy link
Member Author

dougbtv commented Apr 6, 2020

/bugzilla refresh

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@danwinship
Copy link
Contributor

/override ci/prow/e2e-gcp-ovn

@openshift-ci-robot
Copy link
Contributor

@danwinship: Overrode contexts on behalf of danwinship: ci/prow/e2e-gcp-ovn

In response to this:

/override ci/prow/e2e-gcp-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@danwinship
Copy link
Contributor

I SAID
/override ci/prow/e2e-gcp-ovn

@openshift-ci-robot
Copy link
Contributor

@danwinship: Overrode contexts on behalf of danwinship: ci/prow/e2e-gcp-ovn

In response to this:

I SAID
/override ci/prow/e2e-gcp-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knobunc knobunc added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Apr 14, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

11 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit bc9d1e4 into openshift:release-4.4 Apr 15, 2020
@openshift-ci-robot
Copy link
Contributor

@dougbtv: All pull requests linked via external trackers have merged: openshift/cluster-network-operator#528. Bugzilla bug 1812678 has been moved to the MODIFIED state.

In response to this:

Bug 1812678: RBAC for Whereabouts should reference ippools.whereabouts.cni.cncf.io [backport 4.4.z]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanluisvaladas juanluisvaladas Awaiting requested review from juanluisvaladas

@rcarrillocruz rcarrillocruz Awaiting requested review from rcarrillocruz

Assignees

@abhat abhat

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@dougbtv @openshift-ci-robot @abhat @knobunc @openshift-bot @danwinship @openshift-merge-robot