Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KIND deployments for CNO fails. #545

Merged
merged 1 commit into from Mar 19, 2020
Merged

KIND deployments for CNO fails. #545

merged 1 commit into from Mar 19, 2020

Conversation

Billy99
Copy link
Contributor

@Billy99 Billy99 commented Mar 18, 2020

KIND deployments for CNO are failing due to a requirement for existence of
"cluster-config-v1" configMap introduced by merge c594414 on 03/09/2020. This
change adds a minimal "cluster-config-v1" configMap to KIND deployments.

Signed-off-by: Billy McFall 22157057+Billy99@users.noreply.github.com

@Billy99
Copy link
Contributor Author

Billy99 commented Mar 18, 2020

@trozet PTAL

trozet
trozet approved these changes Mar 18, 2020
View reviewed changes
Copy link
Contributor

@trozet trozet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks for fixing it Billy.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 18, 2020
@trozet
Copy link
Contributor

trozet commented Mar 18, 2020

@danwinship PTAL

@Billy99
Copy link
Contributor Author

Billy99 commented Mar 18, 2020

/retest

@alexanderConstantinescu
Copy link
Contributor

Instead of hard-coding NUM_MASTER_NODES=1 maybe you could run a grep -c "role\: control-plane" hack/kind.yaml and remove the commented lines in that file?

Besides that, thanks for fixing this!

@Billy99
Copy link
Contributor Author

Billy99 commented Mar 19, 2020

Instead of hard-coding NUM_MASTER_NODES=1 maybe you could run a grep -c "role\: control-plane" hack/kind.yaml and remove the commented lines in that file?

Besides that, thanks for fixing this!

Thanks for the suggestion, Will do.

@Billy99
KIND deployments for CNO fails.
269faf7 
KIND deployments for CNO are failing due to a requirement for existence of
"cluster-config-v1" configMap introduced by merge c594414 on 03/09/2020. This
change adds a minimal "cluster-config-v1" configMap to KIND deployments.

Signed-off-by: Billy McFall <22157057+Billy99@users.noreply.github.com>
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Mar 19, 2020
@alexanderConstantinescu
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 19, 2020
@openshift-ci-robot
Copy link
Contributor

@Billy99: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-gcp-ovn 269faf7 link /test e2e-gcp-ovn

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@danwinship
Copy link
Contributor

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexanderConstantinescu, Billy99, danwinship, trozet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 19, 2020
@openshift-merge-robot openshift-merge-robot merged commit fc8ccdf into openshift:master Mar 19, 2020
@Billy99 Billy99 deleted the billy99-kind-cno-error branch April 12, 2021 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trozet trozet trozet approved these changes

@alexanderConstantinescu alexanderConstantinescu Awaiting requested review from alexanderConstantinescu

@danwinship danwinship Awaiting requested review from danwinship

Assignees

@trozet trozet

@alexanderConstantinescu alexanderConstantinescu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Billy99 @trozet @alexanderConstantinescu @openshift-ci-robot @danwinship @openshift-merge-robot