Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable KIND debugging in ovn-kind-cno #546

Merged

Conversation

nerdalert
Copy link
Contributor

  • Added a KIND debugging ENV var that takes an int
    which corresponds to the log verbosity level in KIND.
  • The default loglevel is set to 0 which aligns with
    the default loglevel in upstream KIND.

Signed-off-by: Brent Salisbury bsalisbu@redhat.com

- Added a KIND debugging ENV var that takes an int
which corresponds to the log verbosity level in KIND.
- The default loglevel is set to 0 which aligns with
the default loglevel in upstream KIND.

Signed-off-by: Brent Salisbury <bsalisbu@redhat.com>
Copy link
Member

@dave-tucker dave-tucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎖️

@trozet
Copy link
Contributor

trozet commented Mar 25, 2020

@danwinship
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 25, 2020
@trozet
Copy link
Contributor

trozet commented Mar 25, 2020

/approve

1 similar comment
@danwinship
Copy link
Contributor

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danwinship, dave-tucker, nerdalert, trozet, vjayaramrh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 25, 2020
@danwinship
Copy link
Contributor

um, I think
/skip
is the command that makes the bot notice that its test runs went awol

@danwinship
Copy link
Contributor

@nerdalert or you can try closing and then reopening the PR...

@nerdalert
Copy link
Contributor Author

/skip
/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 833e3fc into openshift:master Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants