Deploy the network metrics daemon as part of the CNO. #552
Conversation
openshift-ci-robot
added
the
do-not-merge/work-in-progress
|
Also, this requires openshift/release#7877 to get in as the image is not on quay yet. |
openshift-ci-robot
added
the
needs-rebase
openshift-ci-robot
removed
the
needs-rebase
|
@knobunc do you need if there is something else to do here to make the cluster aware of the new image (especially d/s)? I wonder if there's some black magic involved or I have to configure that somewhere else. |
openshift-ci-robot
added
the
needs-rebase
openshift-ci-robot
removed
the
needs-rebase
fedepaol
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
|
/retest |
|
The daemon is now available on quay, this is good to go. |
|
/retest |
| labels: | ||
| name: openshift-network-metrics | ||
| openshift.io/cluster-monitoring: "true" | ||
| openshift.io/run-level: "1" |
There was a problem hiding this comment.
Since this isn't required for the SDN to run and the operator doesn't consider the daemonset critical, we should consider removing this and use an SCC instead (if necessary).
There was a problem hiding this comment.
It turned out no special capabilities are needed, removed the annotation.
| tolerations: | ||
| - operator: Exists | ||
| containers: | ||
| - name: network-metrics-daemon |
There was a problem hiding this comment.
Doesn't this container need the pod to have hostNetwork: true?
There was a problem hiding this comment.
Nope, at the moment it listens for pods and publish metrics related to the secondary network names
|
/lgtm |
|
/assign @knobunc |
|
/retest |
|
/approve |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brancz, fedepaol, juanluisvaladas, knobunc, pecameron The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/retest Please review the full test history for this PR and help us cut down flakes. |
19 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@fedepaol: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
This PR is to build the network metrics daemon as part of CNO