Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "OVN: Ensure ovn-monitor-all=true before ovn-controller starts." #557

Merged

Conversation

dceara
Copy link
Contributor

@dceara dceara commented Mar 26, 2020

This reverts commit cae57b4 and its
follow up 82d1913. These commits tried
to work around a bug in OVSDB-IDL (https://bugzilla.redhat.com/1808125).

There is no clean and safe way to ensure that ovn-monitor-all=true in
the OVS database so it's better to wait until the proper fix is merged
in OVSDB-IDL instead.

Signed-off-by: Dumitru Ceara dceara@redhat.com

This reverts commit cae57b4 and its
follow up 82d1913. These commits tried
to work around a bug in OVSDB-IDL (https://bugzilla.redhat.com/1808125).

There is no clean and safe way to ensure that ovn-monitor-all=true in
the OVS database so it's better to wait until the proper fix is merged
in OVSDB-IDL instead.

Signed-off-by: Dumitru Ceara <dceara@redhat.com>
@openshift-ci-robot
Copy link
Contributor

Hi @dceara. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 26, 2020
@dcbw
Copy link
Member

dcbw commented Mar 26, 2020

/ok-to-test
/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 26, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dcbw, dceara

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 26, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 0ab14b0 into openshift:master Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants