Bug 1831112: Kuryr: Mount /run/netns to ensure netns access #562
Conversation
openshift-ci-robot
added
the
approved
|
/hold I'd like to get @dcbw opinion here, maybe the breaking change should get reverted instead. |
openshift-ci-robot
added
the
do-not-merge/hold
|
/hold cancel Or let's just merge this and revert it if needed - Kuryr QE needs to get unblocked ASAP as this blocks them from validating 4.4 and 4.3 fixes. |
openshift-ci-robot
removed
the
do-not-merge/hold
dulek
changed the title
|
@dulek: This pull request references Bugzilla bug 1819129, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/invalid-bug
|
/bugzilla refresh |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
@dulek: This pull request references Bugzilla bug 1819129, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
removed
the
bugzilla/invalid-bug
|
/hold Okay, this does not seem to help, somehow it's now "failed to open", probably permissions. |
openshift-ci-robot
added
the
do-not-merge/hold
dulek
force-pushed
the
kuryr-mount-crio
branch
2 times, most recently
from
ac20671
to
823d8db
Compare
dulek
changed the title
openshift-ci-robot
removed
the
bugzilla/valid-bug
|
@dulek: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/retest |
|
(not super important nit; |
|
/retitle Bug: 1831112 Kuryr: Mount /var/run/netns to ensure netns access |
openshift-ci-robot
changed the title
|
/bugzilla refresh |
|
@haircommander: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retitle Bug 1831112: Kuryr: Mount /var/run/netns to ensure netns access |
openshift-ci-robot
changed the title
openshift-ci-robot
added
bugzilla/severity-low
|
@dulek: This pull request references Bugzilla bug 1831112, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
@haircommander: This pull request references Bugzilla bug 1831112, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
removed
the
bugzilla/invalid-bug
|
This seems to be ready now. |
|
LGTM. Should we wait for openshift/machine-config-operator/pull/1689 ? |
openshift/machine-config-operator#1689 moves pod namespaces from /proc into /run/netns. As Kuryr needs access to them in order to manipulate interfaces, we need to mount the new directory and this commit does that. Note that CNI will pass /var/run/netns in netns paths, but /var/run is a symlink to /run, so it should be just fine.
Fixed!
No, if openshift/machine-config-operator#1689 merges without this, we're broken, we should be first. Interestingly we can't remove mounting |
dulek
changed the title
|
/test e2e-gcp |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dulek, luis5tb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@dulek: All pull requests linked via external trackers have merged: openshift/cluster-network-operator#562. Bugzilla bug 1831112 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.4 |
|
@dulek: new pull request created: #684 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift/machine-config-operator#1568 moved pod namespaces from
/proc into /var/run/crio. As Kuryr needs access to them in order to
manipulate interfaces, we need to mount the new directory and this
commit does that.
Most likely the same change needs to be done for ovn-kubernetes, but
it's a bit out of my expertise.