Adds missing OVN NB SSL args to ovnkube master #572
Conversation
|
@dcbw @danwinship PTAL |
|
/test e2e-gcp-ovn |
|
Build issues? /retest |
|
It almost passed ovn-aws, but needs: |
|
/retest |
|
So is there some underlying bug that you're fixing? Or is this just code cleanliness? |
The PR is needed for go-ovn bindings when we get rid of the shell invocations. |
@danwinship it's needed right now because with the SCTP code we use ovsdbclient to check if OVN supports SCTP, and to do that we need NB SSL args. |
|
/retest |
|
/assign @knobunc |
|
/approve |
openshift-ci-robot
added
the
approved
For OVN NB DB interaction with the ovn-nbctl command, we use ovn-nbctl daemon mode, where we do not need to use SSL arguments to directly interact iwth the nbctl socket in the pod. However, SSL arguments are needed for non-nbctl commands like ovsdb client. This patch adds those arguments. In addition, the nbctl-daemon-mode argument was missing as well. This argument indicates to ovn-kubernetes that it needs to use nbctl daemon mode. Even though we were previously not setting this, we were exporting the proper bash env var to allow the process to automatically use daemon mode. However, we should pass the correct arguments to be consistent. Due to an OVN bug, we need to temporarily symlink the ovn-nbctl control socket to /var/run/ovn as it is accidentally placed in /var/run/openvswitch today. Signed-off-by: Tim Rozet <trozet@redhat.com>
trozet
force-pushed
the
ovn_k8s_add_nb_ssl
branch
from
6749b22
to
3a85ce8
Compare
|
/lgtm |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhat, dcbw, pecameron, trozet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@trozet: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
For OVN NB DB interaction with the ovn-nbctl command, we use ovn-nbctl
daemon mode, where we do not need to use SSL arguments to directly
interact with the nbctl socket in the pod. However, SSL arguments are
needed for non-nbctl commands like ovsdb client. This patch adds those
arguments.
In addition, the nbctl-daemon-mode argument was missing as well. This
argument indicates to ovn-kubernetes that it needs to use nbctl daemon
mode. Even though we were previously not setting this, we were exporting
the proper bash env var to allow the process to automatically use daemon
mode. However, we should pass the correct arguments to be consistent.
Due to an OVN bug, we need to temporarily symlink the ovn-nbctl control
socket to /var/run/ovn as it is accidentally placed in
/var/run/openvswitch today.
Signed-off-by: Tim Rozet trozet@redhat.com