Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1822720: Configure TLS for OVN metrics endpoints #581

Merged
merged 1 commit into from Jul 25, 2020
Merged

Bug 1822720: Configure TLS for OVN metrics endpoints #581

merged 1 commit into from Jul 25, 2020

Conversation

juanluisvaladas
Copy link
Contributor

@juanluisvaladas juanluisvaladas commented Apr 9, 2020 •
edited by dcbw

This is a quick workaround for getting OVN metrics using TLS to unblock us...

I will modify OVN kubernetes to be capable to expose HTTPS directly in the near future.

https://issues.redhat.com/browse/SDN-912

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 9, 2020
@dcbw dcbw mentioned this pull request Apr 9, 2020
Closed
@juanluisvaladas juanluisvaladas force-pushed the tls-metrics-ovn branch 2 times, most recently from 3188da5 to 68e7b15 Compare April 9, 2020 14:28
@knobunc
Copy link
Contributor

knobunc commented Apr 9, 2020

We may need to undo this too -- openshift/origin#24853

@dcbw dcbw changed the title [WIP]Configure TLS for OVN metrics endpoints Configure TLS for OVN metrics endpoints Apr 9, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 9, 2020
@dcbw
Copy link
Member

dcbw commented Apr 9, 2020

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 9, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@juanluisvaladas
Copy link
Contributor Author

/retitle Bug 1822720: Configure TLS for OVN metrics endpoints

@openshift-ci-robot openshift-ci-robot changed the title Configure TLS for OVN metrics endpoints Bug 1822720: Configure TLS for OVN metrics endpoints Apr 9, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Apr 9, 2020
@openshift-ci-robot
Copy link
Contributor

@juanluisvaladas: This pull request references Bugzilla bug 1822720, which is invalid:

  • expected the bug to target the "4.5.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1822720: Configure TLS for OVN metrics endpoints

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dcbw
Copy link
Member

dcbw commented Apr 9, 2020

/bugzilla refresh
/retest

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Apr 9, 2020
@openshift-ci-robot
Copy link
Contributor

@dcbw: This pull request references Bugzilla bug 1822720, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh
/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@juanluisvaladas
Copy link
Contributor Author

/retest

None of these seem related to the patch.

@dcbw
Copy link
Member

dcbw commented Apr 9, 2020 •
edited

None of these seem related to the patch.

Actually they are, see https://github.com/openshift/cluster-network-operator/pull/583/files#diff-8bba3a1a9729e2d9c47dcb736aded81dR48 and https://github.com/openshift/cluster-network-operator/pull/583/files#diff-87698f12b12a4457428207bf20f52393R75

Log that led me there: https://storage.googleapis.com/origin-ci-test/pr-logs/pull/openshift_cluster-network-operator/581/pull-ci-openshift-cluster-network-operator-master-e2e-ovn-step-registry/119/artifacts/e2e-ovn-step-registry/gather-extra/pods/openshift-ovn-kubernetes_ovnkube-master-metrics-jm6fp_kube-rbac-proxy.log

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

18 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot
Copy link
Contributor

@juanluisvaladas: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-openstack 44c92ab link /test e2e-openstack
ci/prow/e2e-vsphere 44c92ab link /test e2e-vsphere

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit b1ea43e into openshift:master Jul 25, 2020
@openshift-ci-robot
Copy link
Contributor

@juanluisvaladas: Some pull requests linked via external trackers have merged: . The following pull requests linked via external trackers have not merged:

In response to this:

Bug 1822720: Configure TLS for OVN metrics endpoints

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tssurya added a commit to tssurya/cluster-network-operator that referenced this pull request Aug 3, 2020
@tssurya
OVN: Fix control plane metrics alert job name
6062777 
Following the change in PR openshift#581 the job name should be renamed to
"ovnkube-master-metrics"

Signed-off-by: Surya Seetharaman <suryaseetharaman.9@gmail.com>
@tssurya tssurya mentioned this pull request Aug 3, 2020
Merged
tssurya added a commit to tssurya/cluster-network-operator that referenced this pull request Aug 4, 2020
@tssurya
OVN: Fix control plane metrics alert job name
a9ea052 
Following the change in PR openshift#581 the job name should be renamed to
"ovnkube-master-metrics".

Signed-off-by: Surya Seetharaman <suryaseetharaman.9@gmail.com>
tssurya added a commit to tssurya/cluster-network-operator that referenced this pull request Aug 4, 2020
@tssurya
OVN: Fix control plane metrics alert job name
95f303f 
Following the change in PR openshift#581 the labels in the servicemonitor should be
renamed to "ovnkube-master".

Signed-off-by: Surya Seetharaman <suryaseetharaman.9@gmail.com>
tssurya added a commit to tssurya/cluster-network-operator that referenced this pull request Aug 5, 2020
@tssurya
OVN: Fix control plane metrics alert job name
ea72c82 
Following the change in PR openshift#581 the job name in the alert rule should
be renamed to "ovnkube-master-metrics".

Signed-off-by: Surya Seetharaman <suryaseetharaman.9@gmail.com>
@juanluisvaladas
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@juanluisvaladas: All pull requests linked via external trackers have merged: openshift/cluster-network-operator#581. Bugzilla bug 1822720 has been moved to the MODIFIED state.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squeed squeed squeed left review comments

@dcbw dcbw dcbw left review comments

Assignees

@rcarrillocruz rcarrillocruz

@dcbw dcbw

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@juanluisvaladas @knobunc @dcbw @openshift-bot @openshift-ci-robot @squeed @tsmetana @rcarrillocruz @openshift-merge-robot