Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'complete' typo in README #614

Merged
merged 1 commit into from Jun 2, 2020
Merged

Fix 'complete' typo in README #614

merged 1 commit into from Jun 2, 2020

Conversation

Dysproz
Copy link
Contributor

@Dysproz Dysproz commented May 5, 2020

It should be 'complete', not 'coplete' :)

It should be complete, not coplete :)
@openshift-ci-robot openshift-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 5, 2020
@openshift-ci-robot
Copy link
Contributor

Hi @Dysproz. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Dysproz
Copy link
Contributor Author

Dysproz commented May 5, 2020

/assign @squeed

@danwinship
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 5, 2020
@Dysproz
Copy link
Contributor Author

Dysproz commented May 5, 2020

/retest

@openshift-ci-robot
Copy link
Contributor

@Dysproz: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Dysproz
Copy link
Contributor Author

Dysproz commented May 5, 2020

/retest

@openshift-ci-robot
Copy link
Contributor

@Dysproz: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@danwinship
Copy link
Contributor

/ok-to-test
/retest

@openshift-ci-robot openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 5, 2020
@Dysproz
Copy link
Contributor Author

Dysproz commented May 15, 2020

@danwinship Do I need to create ticket in bugzilla or something in order to merge it?

@danwinship
Copy link
Contributor

No, it will merge eventually once 4.5 branches and master opens for 4.6 development

@Dysproz
Copy link
Contributor Author

Dysproz commented Jun 1, 2020

/retest

2 similar comments
@Dysproz
Copy link
Contributor Author

Dysproz commented Jun 1, 2020

/retest

@Dysproz
Copy link
Contributor Author

Dysproz commented Jun 1, 2020

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

Copy link
Contributor

@pecameron pecameron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danwinship, Dysproz, pecameron

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@Dysproz
Copy link
Contributor Author

Dysproz commented Jun 1, 2020

/retest

1 similar comment
@Dysproz
Copy link
Contributor Author

Dysproz commented Jun 2, 2020

/retest

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 2, 2020

@Dysproz: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-vsphere 7c2416a link /test e2e-vsphere

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@squeed
Copy link
Contributor

squeed commented Jun 2, 2020

/override ci/prow/e2e-aws-sdn-single ci/prow/e2e-gcp

@openshift-ci-robot
Copy link
Contributor

@squeed: /override requires a failed status context to operate on.
The following unknown contexts were given:

  • ci/prow/e2e-aws-sdn-single ci/prow/e2e-gcp

Only the following contexts were expected:

  • ci/prow/e2e-aws-sdn-multi
  • ci/prow/e2e-aws-sdn-single
  • ci/prow/e2e-gcp
  • ci/prow/e2e-gcp-ovn
  • ci/prow/e2e-gcp-upgrade
  • ci/prow/e2e-metal-ipi
  • ci/prow/e2e-ovn-hybrid-step-registry
  • ci/prow/e2e-ovn-step-registry
  • ci/prow/e2e-vsphere
  • ci/prow/e2e-windows-hybrid-network
  • ci/prow/images
  • ci/prow/unit
  • ci/prow/verify
  • tide

In response to this:

/override ci/prow/e2e-aws-sdn-single ci/prow/e2e-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@squeed
Copy link
Contributor

squeed commented Jun 2, 2020

/override ci/prow/e2e-aws-sdn-single
/override ci/prow/e2e-gcp

@openshift-ci-robot
Copy link
Contributor

@squeed: Overrode contexts on behalf of squeed: ci/prow/e2e-aws-sdn-single, ci/prow/e2e-gcp

In response to this:

/override ci/prow/e2e-aws-sdn-single
/override ci/prow/e2e-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 863f8ba into openshift:master Jun 2, 2020
@Dysproz Dysproz deleted the patch-1 branch June 2, 2020 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants