New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1833372: Drop 'dep verify' from verify-style #630
Bug 1833372: Drop 'dep verify' from verify-style #630
Conversation
As a prologue to switching to go modules, to help untangle CNO-vs-openshift/release interdependencies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danwinship, pecameron The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest Please review the full test history for this PR and help us cut down flakes. |
@danwinship: This pull request references Bugzilla bug 1833372, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@danwinship: This pull request references Bugzilla bug 1833372, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@danwinship i removed the dep check in my PR as well, do you want me to remove it ? |
LGTM |
/retest Please review the full test history for this PR and help us cut down flakes. |
/override ci/prow/e2e-gcp |
@danwinship: Overrode contexts on behalf of danwinship: ci/prow/e2e-gcp In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@danwinship: Some pull requests linked via external trackers have merged: . The following pull requests linked via external trackers have not merged:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
ci/prow/verify is failing in #616 because of weird interactions between "go get" and "migrating to go modules", but we can't fix either side without breaking the other unless we do this first
@squeed @dcbw @rcarrillocruz
(cc @vishnoianil )