Bug 1820472: Not delete namespace object when cleanup not rended objects #641
Conversation
pliurh
changed the title
openshift-ci-robot
added
bugzilla/severity-high
|
@pliurh: This pull request references Bugzilla bug 1820472, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test verify |
|
/retest |
|
I am not sure if one can chose to go from "multus deployment -> non multus deployment", which would have the multus namespace linger around with this patch. @squeed, any input on that? |
|
/retest |
That's correct - disabling multus after-the-fact is not supported. I think this is a better approach; could you add a quick comment in the code as to why this was added, then I'll lgtm it? |
pliurh
force-pushed
the
not-delete-namespace
branch
2 times, most recently
from
40cc71c
to
0c5ce3b
Compare
|
@squeed PTAL |
| @@ -85,6 +85,12 @@ func (status *StatusManager) deleteRelatedObjectsNotRendered(co *configv1.Cluste | |||
| status.relatedObjects = append(status.relatedObjects, currentObj) | |||
| continue | |||
| } | |||
| if gvk.Kind == "Namespace" { | |||
There was a problem hiding this comment.
Check that gvk.Group == "core" too.
There was a problem hiding this comment.
In the namespace gvk object, the group is empty string, so I change use gvk.Group == "" here.
pliurh
force-pushed
the
not-delete-namespace
branch
from
0c5ce3b
to
1cf0fbb
Compare
Namespace deletion cannot be done while openshift-apiserver is down. It will be stuck in 'Terminating' state forever, and that can block the sdn restore. So we choose not delete the namespace by the cleanup function, but leave it to the user to manually remove the namesapce, after the cluster is back to normal state.
|
/retest |
|
/test e2e-windows-hybrid-network |
|
/test e2e-metal-ipi |
1 similar comment
|
/test e2e-metal-ipi |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pliurh, squeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@pliurh: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@pliurh: Some pull requests linked via external trackers have merged: . The following pull requests linked via external trackers have not merged:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Namespace deletion cannot be done while openshift-apiserver is down. It will be stuck in 'Terminating' state forever, and that can block the sdn restore. So we choose not to delete the namespace by the cleanup function but leave it to the user to manually remove the namespace after the cluster is back to a normal state.