Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1846396: Drop ovn-octavia provider limitation for multiprotocol listeners #656

Merged

Conversation

luis5tb
Copy link
Contributor

@luis5tb luis5tb commented Jun 1, 2020

The ovn-octavia limitation of having several listener protocols
on the same port has been fixed, so the exception made for it
is not needed anymore.

@luis5tb
Copy link
Contributor Author

luis5tb commented Jun 1, 2020

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 1, 2020
@luis5tb luis5tb force-pushed the drop-ovn-octavia-limitation branch from 06a8f48 to b7402b4 Compare June 1, 2020 12:38
@luis5tb
Copy link
Contributor Author

luis5tb commented Jun 1, 2020

/retest

2 similar comments
@luis5tb
Copy link
Contributor Author

luis5tb commented Jun 2, 2020

/retest

@luis5tb
Copy link
Contributor Author

luis5tb commented Jun 5, 2020

/retest

@dulek
Copy link
Contributor

dulek commented Jun 8, 2020

Any reason to keep it on hold?

@dulek
Copy link
Contributor

dulek commented Jun 8, 2020

/retest

1 similar comment
@luis5tb
Copy link
Contributor Author

luis5tb commented Jun 9, 2020

/retest

The ovn-octavia limitation of having several listener protocols
on the same port has been fixed, so the exception made for it
is not needed anymore.
@luis5tb luis5tb force-pushed the drop-ovn-octavia-limitation branch from b7402b4 to 9d2fe88 Compare June 11, 2020 13:48
@luis5tb luis5tb changed the title Drop ovn-octavia provider limitation for multiprotocol listeners Bug 1846396: Drop ovn-octavia provider limitation for multiprotocol listeners Jun 11, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jun 11, 2020
@openshift-ci-robot
Copy link
Contributor

@luis5tb: This pull request references Bugzilla bug 1846396, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1846396: Drop ovn-octavia provider limitation for multiprotocol listeners

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@luis5tb
Copy link
Contributor Author

luis5tb commented Jun 11, 2020

Any reason to keep it on hold?

We need to merge first the kuryr-controller side

@luis5tb
Copy link
Contributor Author

luis5tb commented Jun 11, 2020

/retest

@luis5tb
Copy link
Contributor Author

luis5tb commented Jun 11, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 11, 2020
@luis5tb
Copy link
Contributor Author

luis5tb commented Jun 11, 2020

/retest

@MaysaMacedo
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 11, 2020
@luis5tb
Copy link
Contributor Author

luis5tb commented Jun 15, 2020

/retest

@luis5tb
Copy link
Contributor Author

luis5tb commented Jun 15, 2020

/test e2e-vsphere

@luis5tb
Copy link
Contributor Author

luis5tb commented Jun 15, 2020

/approve

@luis5tb
Copy link
Contributor Author

luis5tb commented Jun 15, 2020

/assign @dulek

@luis5tb
Copy link
Contributor Author

luis5tb commented Jun 15, 2020

/test e2e-metal-ipi

@luis5tb
Copy link
Contributor Author

luis5tb commented Jun 15, 2020

/test e2e-vsphere

1 similar comment
@luis5tb
Copy link
Contributor Author

luis5tb commented Jun 15, 2020

/test e2e-vsphere

@luis5tb
Copy link
Contributor Author

luis5tb commented Jun 15, 2020

/retest

3 similar comments
@luis5tb
Copy link
Contributor Author

luis5tb commented Jun 15, 2020

/retest

@luis5tb
Copy link
Contributor Author

luis5tb commented Jun 15, 2020

/retest

@luis5tb
Copy link
Contributor Author

luis5tb commented Jun 16, 2020

/retest

@dulek
Copy link
Contributor

dulek commented Jun 16, 2020

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dulek, luis5tb, MaysaMacedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 16, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@luis5tb
Copy link
Contributor Author

luis5tb commented Jun 16, 2020

/test e2e-gcp-ovn

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 2a56600 into openshift:master Jun 16, 2020
@openshift-ci-robot
Copy link
Contributor

@luis5tb: All pull requests linked via external trackers have merged: openshift/kuryr-kubernetes#278, openshift/cluster-network-operator#656. Bugzilla bug 1846396 has been moved to the MODIFIED state.

In response to this:

Bug 1846396: Drop ovn-octavia provider limitation for multiprotocol listeners

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@luis5tb
Copy link
Contributor Author

luis5tb commented Jun 16, 2020

/cherry-pick release-4.5

@openshift-cherrypick-robot

@luis5tb: new pull request created: #673

In response to this:

/cherry-pick release-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants