Improve IPv6 testing and minor fixes #660
Conversation
the function checks if the IP is invalid, but instead of returning and empty value, it logs the error and returns the invalid value Signed-off-by: Antonio Ojea <aojea@redhat.com>
the getAddressAndPort method was using a signed integer with 16 bits to convert the port string to a number, thus only -32,768 to 32,767 were allowed. Using an unsigned integer with 16 bits solves the problem Signed-off-by: Antonio Ojea <aojea@redhat.com>
IPv6 addresses must be enclosed in square brackets when used in address:port format. Signed-off-by: Antonio Ojea <aojea@redhat.com>
|
/assign @dcbw @danwinship |
|
you may want to rebase to single commit |
I prefer not to, since every commit is totally independent and, in case of an error, it will be easier to revert just the offending one. |
yeah. We don't want PRs with one real commit and a bunch of fixes to it, but if the commit is logically made up of multiple pieces, go with multiple commits |
Signed-off-by: Antonio Ojea <aojea@redhat.com>
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aojea, danwinship The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
6 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@aojea: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Aggregated several commits in the PR because I was finding several issues.
It was reported that the cluster-network-operator wasn't configuring correctly kube-proxy bind-address if it was "::", so I added some unit tests to check that it works correctly.
The other fixes are explained in the commit messages.