Bug 1824983: explicitly delete pidfiles when exiting #661
Conversation
saw this error message in the logs
Terminated:&ContainerStateTerminated{ExitCode:1,Signal:0,Reason:Error,Message:ovsdb-server: /var/run/openvswitch/ovsdb-server.pid: pidfile check failed (No such process)
when it looked like ovs was restarting causing the sdn pods to spin. explicitly delete
/var/run/openvswitch/ovs-vswitchd.pid and
/var/run/openvswitch/ovsdb-server.pid:
on ovs pod exit
|
/retest |
1 similar comment
|
/retest |
So this fix seems to be counter-intuitive to the error message. The error message is saying that the pod termination failed because the pid file wasn't found. And we are trying to fix that by adding a |
|
@abhat it is more important that it runs on the previous iteration of the ovs pod. We want to make sure that we clean up the pidfile before another container tries to start since /var/run is mounted from the host when the container exits if the file remains it could cause problems like this |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhat, JacobTanenbaum The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
Is there a bz to tag this with @JacobTanenbaum? |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
JacobTanenbaum
changed the title
JacobTanenbaum
changed the title
openshift-ci-robot
added
the
bugzilla/severity-high
|
@JacobTanenbaum: This pull request references Bugzilla bug 1824983, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
/retest Please review the full test history for this PR and help us cut down flakes. |
7 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@JacobTanenbaum: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@JacobTanenbaum: All pull requests linked via external trackers have merged: openshift/cluster-network-operator#661. Bugzilla bug 1824983 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
saw this error message in the logs
Terminated:&ContainerStateTerminated{ExitCode:1,Signal:0,Reason:Error,Message:ovsdb-server: /var/run/openvswitch/ovsdb-server.pid: pidfile check failed (No such process)
when it looked like ovs was restarting causing the sdn pods to spin. explicitly delete
/var/run/openvswitch/ovs-vswitchd.pid and
/var/run/openvswitch/ovsdb-server.pid:
on ovs pod exit