Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.4] [release-4.5] Bug 1847558: Drop ovn-octavia provider limitation for multiprotocol listeners #675

Merged
merged 1 commit into from Jul 2, 2020
Merged

[release-4.4] [release-4.5] Bug 1847558: Drop ovn-octavia provider limitation for multiprotocol listeners #675

merged 1 commit into from Jul 2, 2020

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #673

/assign luis5tb

@luis5tb
Drop ovn-octavia provider limitation for multiprotocol listeners
59126f2 
The ovn-octavia limitation of having several listener protocols
on the same port has been fixed, so the exception made for it
is not needed anymore.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 18, 2020
Merged
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Detected clone of Bugzilla bug 1846452 with correct target release. Retitling PR to link to clone:
/retitle [release-4.4] [release-4.5] Bug 1847558: Drop ovn-octavia provider limitation for multiprotocol listeners

In response to this:

[release-4.4] [release-4.5] Bug 1846452: Drop ovn-octavia provider limitation for multiprotocol listeners

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot changed the title [release-4.4] [release-4.5] Bug 1846452: Drop ovn-octavia provider limitation for multiprotocol listeners [release-4.4] [release-4.5] Bug 1847558: Drop ovn-octavia provider limitation for multiprotocol listeners Jun 18, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. label Jun 18, 2020
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1847558, which is invalid:

  • expected dependent Bugzilla bug 1846452 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.4] [release-4.5] Bug 1847558: Drop ovn-octavia provider limitation for multiprotocol listeners

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jun 18, 2020
@luis5tb
Copy link
Contributor

luis5tb commented Jun 18, 2020

/approve

@luis5tb
Copy link
Contributor

luis5tb commented Jun 19, 2020

/test e2e-gcp-upgrade

@luis5tb
Copy link
Contributor

luis5tb commented Jun 25, 2020

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jun 25, 2020
@openshift-ci-robot
Copy link
Contributor

@luis5tb: This pull request references Bugzilla bug 1847558, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.4.z) matches configured target release for branch (4.4.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1846452 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1846452 targets the "4.5.0" release, which is one of the valid target releases: 4.5.0, 4.5.z
  • bug has dependents

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jun 25, 2020
@luis5tb
Copy link
Contributor

luis5tb commented Jun 25, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 25, 2020
@openshift-ci-robot openshift-ci-robot mentioned this pull request Jun 25, 2020
Merged
@luis5tb
Copy link
Contributor

luis5tb commented Jun 26, 2020

/approve

@dulek
Copy link
Contributor

dulek commented Jun 29, 2020

/approve
/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dulek, luis5tb, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 29, 2020
@sdodson sdodson added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jul 2, 2020
@openshift-merge-robot openshift-merge-robot merged commit 401ac3e into openshift:release-4.4 Jul 2, 2020
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged: openshift/kuryr-kubernetes#286, openshift/cluster-network-operator#675. Bugzilla bug 1847558 has been moved to the MODIFIED state.

In response to this:

[release-4.4] [release-4.5] Bug 1847558: Drop ovn-octavia provider limitation for multiprotocol listeners

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@celebdor celebdor Awaiting requested review from celebdor

@dulek dulek Awaiting requested review from dulek

Assignees

@dulek dulek

@luis5tb luis5tb

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@openshift-cherrypick-robot @openshift-ci-robot @luis5tb @dulek @sdodson @openshift-merge-robot