Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1851518: Expose raft (nb-db/sb-db) election-timer and ovn-controller inactivity probe. #682

Merged
merged 4 commits into from Jun 28, 2020
Merged

Bug 1851518: Expose raft (nb-db/sb-db) election-timer and ovn-controller inactivity probe. #682

merged 4 commits into from Jun 28, 2020

Conversation

vishnoianil
Copy link
Contributor

These timers are currently set to fixed value based on my current observation
from scale tests. We might have to increase these values in future based on
the scale we will be supporting for upcoming release. Currently election-timer
values are limited by the raft jsonrpc inactivity-probe time of 5 seconds as well.
To further increase the election-timer value, we need to disable jsonrpc
inactivity-probe.

Signed-off-by: Anil Vishnoi avishnoi@redhat.com

@vishnoianil
Expose raft (nb-db/sb-db) election-timer and ovn-controller inactivit…
f95dbea 
…y-probe.

These timers are currently set to fixed value based on my current observation
from scale tests. We might have to increase these values in future based on
the scale we will be supporting for upcoming release. Currently election-timer
values are limited by the raft jsonrpc inactivity-probe time of 5 seconds as well.
To further increase the election-timer value, we need to disable jsonrpc
inactivity-probe.

Signed-off-by: Anil Vishnoi <avishnoi@redhat.com>
@vishnoianil
Fix review comment - Remove the test OVN_IMAGE url
63a1aea 
Signed-off-by: Anil Vishnoi <avishnoi@redhat.com>
@vishnoianil
Fix review comments:
e834dbe 
> Fix regular expression
> Improve the conditions check

Signed-off-by: Anil Vishnoi <avishnoi@redhat.com>
@vishnoianil
Fix CI failures
78d6aa0 
Typo in election_timer was assigning null value that was leading to
failure in setting up the nb-db election-timer (only if you use != 2(n) number).
Seems like it was delaying the deployment of ovnkube-master and
causing issue with ovnkube-node readiness as the flow programming got delayed
and ovnkube-node times out checking for flows.

Signed-off-by: Anil Vishnoi <avishnoi@redhat.com>
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jun 26, 2020
@openshift-ci-robot
Copy link
Contributor

@vishnoianil: This pull request references Bugzilla bug 1822296, which is invalid:

  • expected the bug to target the "4.5.0" release, but it targets "4.6.0" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is ON_QA instead
  • expected Bugzilla bug 1822296 to depend on a bug targeting a release in 4.6.0, 4.6.z and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1822296: Expose raft (nb-db/sb-db) election-timer and ovn-controller inactivity probe.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vishnoianil
Copy link
Contributor Author

@dcbw PTAL, thanks

@vishnoianil vishnoianil changed the title Bug 1822296: Expose raft (nb-db/sb-db) election-timer and ovn-controller inactivity probe. Bug 1851518: Expose raft (nb-db/sb-db) election-timer and ovn-controller inactivity probe. Jun 26, 2020
@openshift-ci-robot
Copy link
Contributor

@vishnoianil: This pull request references Bugzilla bug 1851518, which is invalid:

  • expected the bug to target the "4.5.0" release, but it targets "4.6.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1851518: Expose raft (nb-db/sb-db) election-timer and ovn-controller inactivity probe.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vishnoianil
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@vishnoianil: This pull request references Bugzilla bug 1851518, which is invalid:

  • expected the bug to target the "4.5.0" release, but it targets "4.6.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vishnoianil
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jun 26, 2020
@openshift-ci-robot
Copy link
Contributor

@vishnoianil: This pull request references Bugzilla bug 1851518, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1822296 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Bugzilla bug 1822296 targets the "4.6.0" release, which is one of the valid target releases: 4.6.0, 4.6.z
  • bug has dependents

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dcbw
Copy link
Contributor

dcbw commented Jun 26, 2020

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 26, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dcbw, vishnoianil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 26, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@sdodson sdodson added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jun 28, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 9539e49 into openshift:release-4.5 Jun 28, 2020
@openshift-ci-robot
Copy link
Contributor

@vishnoianil: All pull requests linked via external trackers have merged: openshift/cluster-network-operator#682. Bugzilla bug 1851518 has been moved to the MODIFIED state.

In response to this:

Bug 1851518: Expose raft (nb-db/sb-db) election-timer and ovn-controller inactivity probe.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dcbw
Copy link
Contributor

dcbw commented Jun 29, 2020

/cherry-pick release-4.4

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 29, 2020
Closed
@openshift-cherrypick-robot
Copy link

@dcbw: new pull request created: #685

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderConstantinescu alexanderConstantinescu Awaiting requested review from alexanderConstantinescu

@dcbw dcbw Awaiting requested review from dcbw

Assignees

@dcbw dcbw

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@vishnoianil @openshift-ci-robot @dcbw @openshift-bot @openshift-cherrypick-robot @sdodson @openshift-merge-robot