New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump OVN Bootstrap timeout #690
Bump OVN Bootstrap timeout #690
Conversation
8972fff
to
6a672d0
Compare
/assign @danwinship |
/lgtm |
/retest |
@abhat @dcbw @danwinship can one of you please approve? |
/retest |
@@ -232,7 +232,7 @@ func boostrapOVN(kubeClient client.Client) (*bootstrap.BootstrapResult, error) { | |||
|
|||
controlPlaneReplicaCount, _ := strconv.Atoi(rcD.ControlPlane.Replicas) | |||
|
|||
err := wait.PollImmediate(2*time.Second, 60*time.Second, func() (bool, error) { | |||
err := wait.PollImmediate(5*time.Second, 280*time.Second, func() (bool, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
out of curiosity,:
- any particular reason why we also bumped the polling interval to 5secs? - just to reflect the relativity wrt to the timeout interval?
- do we know approximately how long it takes with the new model?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Yes
- No, neither I nor @trozet performed a real study on the time it normally takes, and what we should set these values to....but then again, that was never the case the first time we implemented this mechanism either. With OVS running on the node and attached to the primary NIC it has however been seen that nodes might boot a bit slower due to DHCP issues: Configure OVS NIC for OVN machine-config-operator#1860 (comment).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
understood, thanks for clarifying Alex.
/test e2e-gcp-ovn |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexanderConstantinescu, danwinship, trozet, tssurya The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
8 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
@alexanderConstantinescu: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest Please review the full test history for this PR and help us cut down flakes. |
Today we wait for 1 minute for all nodes to be up before booting OVN. With "OVS on the system" there is additional configuration done by NetworkManager / MCO networking startup scripts and the likes, which might require longer timeouts than what we currently support. So, let's bump the time.
Reconciliation happens every 5 min, so I am setting the timeout to 280 seconds to not block reconciliation during bring up.
/assign @trozet