New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable multicast support by default on the master #711
Conversation
hm... |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhat, danwinship The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@dcbw mentioned that we may not want to do this upstream by default since it does incur some penalty. |
Right, not saying we should change the default upstream, just that you should be able to specify the option in the config file rather than having to do it on the command line. |
/retest Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
@abhat: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest Please review the full test history for this PR and help us cut down flakes. |
The daemonset file currently doesn't enable multicast support by default. This change is to pass that as an argument during starting of the ovnkube-master pod.