Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1856130: [release-4.5] bump golang.org/x/text/encoding to v0.3.3 #714

Merged
merged 1 commit into from Aug 17, 2020
Merged

Bug 1856130: [release-4.5] bump golang.org/x/text/encoding to v0.3.3 #714

merged 1 commit into from Aug 17, 2020

Conversation

aojea
Copy link
Contributor

@aojea aojea commented Jul 16, 2020

CVE-2020-14040 golang.org/x/text: possibility to trigger an
infinite loop in encoding/unicode could lead to crash.

Upgrade to golang.org/x/text/encoding to v0.3.3

Signed-off-by: Antonio Ojea aojea@redhat.com

bump golang.org/x/text/encoding
6e35e0f 
CVE-2020-14040 golang.org/x/text: possibility to trigger an
infinite loop in encoding/unicode could lead to crash.

Upgrade to golang.org/x/text/encoding to v0.3.3

Signed-off-by: Antonio Ojea <aojea@redhat.com>
@openshift-ci-robot
Copy link
Contributor

@aojea: This pull request references Bugzilla bug 1856130, which is invalid:

  • expected the bug to target the "4.5.z" release, but it targets "4.6.0" instead
  • expected Bugzilla bug 1856130 to depend on a bug targeting a release in 4.6.0, 4.6.z and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1856130: [release-4.5] bump golang.org/x/text/encoding to v0.3.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jul 16, 2020
@aojea
Copy link
Contributor Author

aojea commented Jul 17, 2020

/assign @rcarrillocruz @alexanderConstantinescu
/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@aojea: This pull request references Bugzilla bug 1856130, which is invalid:

  • expected the bug to target the "4.5.z" release, but it targets "4.6.0" instead
  • expected Bugzilla bug 1856130 to depend on a bug targeting a release in 4.6.0, 4.6.z and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/assign @rcarrillocruz @alexanderConstantinescu
/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aojea
Copy link
Contributor Author

aojea commented Jul 17, 2020

/retest

@aojea
Copy link
Contributor Author

aojea commented Jul 17, 2020

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@aojea: This pull request references Bugzilla bug 1856130, which is invalid:

  • expected Bugzilla bug 1856130 to depend on a bug targeting a release in 4.6.0, 4.6.z and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@alexanderConstantinescu
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 20, 2020
@alexanderConstantinescu
Copy link
Contributor

Just FMI (for my information...): I didn't see a master PR with this patch, do you have one @aojea ?

@aojea
Copy link
Contributor Author

aojea commented Jul 20, 2020

Just FMI (for my information...): I didn't see a master PR with this patch, do you have one @aojea ?

Master is not affected @alexanderConstantinescu

The fix is in golang.org/x/text v0.3.3,

4.5 and lower needs to upgrade the module to the v0.3.3 version

@alexanderConstantinescu
Copy link
Contributor

Just FMI (for my information...): I didn't see a master PR with this patch, do you have one @aojea ?

Master is not affected @alexanderConstantinescu

The fix is in golang.org/x/text v0.3.3,

4.5 and lower needs to upgrade the module to the v0.3.3 version

ACK, thanks for clarifying. We might need a "dummy bug" in that case that targets 4.6, so that this PR can go in.

@aojea
Copy link
Contributor Author

aojea commented Jul 20, 2020

/cherry-pick release-4.4

@openshift-cherrypick-robot
Copy link

@aojea: once the present PR merges, I will cherry-pick it on top of release-4.4 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aojea
Copy link
Contributor Author

aojea commented Jul 20, 2020

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@aojea: This pull request references Bugzilla bug 1856130, which is invalid:

  • expected dependent Bugzilla bug 1858837 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ASSIGNED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

@openshift-ci-robot
Copy link
Contributor

@openshift-bot: This pull request references Bugzilla bug 1856130, which is invalid:

  • expected dependent Bugzilla bug 1858837 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

@openshift-ci-robot
Copy link
Contributor

@openshift-bot: Bugzilla bug 1856130 is in a bug group that is not in the allowed groups for this repo. There are no allowed bug groups configured for this repo.

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

@openshift-ci-robot
Copy link
Contributor

@openshift-bot: Bugzilla bug 1856130 is in a bug group that is not in the allowed groups for this repo. There are no allowed bug groups configured for this repo.

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knobunc
Copy link
Contributor

knobunc commented Jul 23, 2020

@aojea the bot will be fixed when openshift/release#10440 merges.

@openshift-bot
Copy link
Contributor

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

25 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 6032370 into openshift:release-4.5 Aug 17, 2020
@openshift-ci-robot
Copy link
Contributor

@aojea: All pull requests linked via external trackers have merged: openshift/cluster-network-operator#714. Bugzilla bug 1856130 has been moved to the MODIFIED state.

In response to this:

Bug 1856130: [release-4.5] bump golang.org/x/text/encoding to v0.3.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Aug 17, 2020
Closed
@openshift-cherrypick-robot
Copy link

@aojea: new pull request created: #757

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcarrillocruz rcarrillocruz Awaiting requested review from rcarrillocruz

@squeed squeed Awaiting requested review from squeed

Assignees

@rcarrillocruz rcarrillocruz

@alexanderConstantinescu alexanderConstantinescu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@aojea @openshift-ci-robot @alexanderConstantinescu @openshift-cherrypick-robot @openshift-bot @knobunc @sdodson @mrunalp @rcarrillocruz @openshift-merge-robot