Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1858712: Revert "[release-4.5] Bug 1854072: Check if the db file has been correctly initialized with raft. #718

Conversation

abhat
Copy link
Contributor

@abhat abhat commented Jul 20, 2020

Reverts #693

@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Jul 20, 2020
@openshift-ci-robot
Copy link
Contributor

@abhat: This pull request references Bugzilla bug 1854072, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is VERIFIED instead
  • expected dependent Bugzilla bug 1857455 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead
  • expected dependent Bugzilla bug 1857462 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is NEW instead
  • expected dependent Bugzilla bug 1857462 to target a release in 4.6.0, 4.6.z, but it targets "4.5.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Revert "[release-4.5] Bug 1854072: Check if the db file has been correctly initialized with raft."

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jul 20, 2020
@abhat abhat changed the title Revert "[release-4.5] Bug 1854072: Check if the db file has been correctly initialized with raft." Bug 1858712: Revert "[release-4.5] Bug 1854072: Check if the db file has been correctly initialized with raft." Jul 20, 2020
@openshift-ci-robot
Copy link
Contributor

@abhat: This pull request references Bugzilla bug 1858712, which is invalid:

  • expected the bug to target the "4.5.z" release, but it targets "---" instead
  • expected Bugzilla bug 1858712 to depend on a bug targeting a release in 4.6.0, 4.6.z and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1858712: Revert "[release-4.5] Bug 1854072: Check if the db file has been correctly initialized with raft."

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 20, 2020
@abhat
Copy link
Contributor Author

abhat commented Jul 20, 2020

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@abhat: This pull request references Bugzilla bug 1858712, which is invalid:

  • expected Bugzilla bug 1858712 to depend on a bug targeting a release in 4.6.0, 4.6.z and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sdodson sdodson added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jul 20, 2020
@alexanderConstantinescu
Copy link
Contributor

/lgtm

/cc @fedepaol , please confirm that this is good

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 20, 2020
@fedepaol
Copy link
Member

/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhat, alexanderConstantinescu, fedepaol

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

@abhat: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-ovn-hybrid-step-registry 862c486 link /test e2e-ovn-hybrid-step-registry

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@wking
Copy link
Member

wking commented Jul 20, 2020

/retitle Bug 1854072: Revert "[release-4.5] Bug 1854072: Check if the db file has been correctly initialized with raft."

@openshift-ci-robot openshift-ci-robot changed the title Bug 1858712: Revert "[release-4.5] Bug 1854072: Check if the db file has been correctly initialized with raft." Bug 1854072: Revert "[release-4.5] Bug 1854072: Check if the db file has been correctly initialized with raft." Jul 20, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. and removed bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jul 20, 2020
@openshift-ci-robot
Copy link
Contributor

@abhat: This pull request references Bugzilla bug 1854072, which is invalid:

  • expected dependent Bugzilla bug 1857455 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead
  • expected dependent Bugzilla bug 1857462 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is NEW instead
  • expected dependent Bugzilla bug 1857462 to target a release in 4.6.0, 4.6.z, but it targets "4.5.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1854072: Revert "[release-4.5] Bug 1854072: Check if the db file has been correctly initialized with raft."

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sdodson
Copy link
Member

sdodson commented Jul 20, 2020

/retitle Bug 1854072: Revert "[release-4.5] Bug 1854072: Check if the db file has been correctly initialized with raft."

I don't think that was the right thing to do since we're fixing the regresison but not the original bug.

/retitle Bug 1858712: Revert "[release-4.5] Bug 1854072: Check if the db file has been correctly initialized with raft.

@openshift-ci-robot openshift-ci-robot changed the title Bug 1854072: Revert "[release-4.5] Bug 1854072: Check if the db file has been correctly initialized with raft." Bug 1858712: Revert "[release-4.5] Bug 1854072: Check if the db file has been correctly initialized with raft. Jul 20, 2020
@openshift-ci-robot
Copy link
Contributor

@abhat: This pull request references Bugzilla bug 1858712, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is MODIFIED instead
  • expected dependent Bugzilla bug 1837953 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead
  • expected dependent Bugzilla bug 1858834 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is CLOSED (DUPLICATE) instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1858712: Revert "[release-4.5] Bug 1854072: Check if the db file has been correctly initialized with raft.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sdodson sdodson removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jul 20, 2020
@sdodson sdodson added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. labels Jul 20, 2020
@openshift-merge-robot openshift-merge-robot merged commit f548086 into openshift:release-4.5 Jul 20, 2020
@openshift-ci-robot
Copy link
Contributor

@abhat: All pull requests linked via external trackers have merged: openshift/cluster-network-operator#718. Bugzilla bug 1858712 has been moved to the MODIFIED state.

In response to this:

Bug 1858712: Revert "[release-4.5] Bug 1854072: Check if the db file has been correctly initialized with raft.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants