Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.5] Bug 1855894: Add netns mount #730

Merged
merged 1 commit into from Jul 31, 2020
Merged

[release-4.5] Bug 1855894: Add netns mount #730

merged 1 commit into from Jul 31, 2020

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #696

/assign knobunc

@pecameron
Bug 1852593: Add netns mount
be56c9b 
1852593 - EgressRouter: error in getting result from AddNetwork: CNI request failed with status 400
https://bugzilla.redhat.com/show_bug.cgi?id=1852593

Failed to create pod sandbox: rpc error: code = Unknown desc = failed to create pod network sandbox k8s_egress-redirect-pod_test_d22d4544-18ec-43bf-95c4-70f21e5246fe_0(4d0cbd2631875f117df10c0a8501b385919b1162f40382e75b8c87b8bb3cf7ca): Multus: [test/egress-redirect-pod]: error adding container to network "openshift-sdn": delegateAdd: error invoking confAdd - "openshift-sdn": error in getting result from AddNetwork: CNI request failed with status 400: 'could not open netns "/var/run/netns/11cb808b-c141-40e9-86fe-c74643b481aa": unknown FS magic on "/var/run/netns/11cb808b-c141-40e9-86fe-c74643b481aa": 1021994

Fix by mounting /run/netns in container as HostToContainer

Signed-off-by: Phil Cameron <pcameron@redhat.com>
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: An error was encountered searching for bug 0 on the Bugzilla server at https://bugzilla.redhat.com:

code 101: Bug #0 does not exist.
Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

[release-4.5] Bug 1852593: Add netns mount

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 28, 2020
Merged
@knobunc knobunc changed the title [release-4.5] Bug 1852593: Add netns mount [release-4.5] Bug 1855894: Add netns mount Jul 28, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Jul 28, 2020
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1855894, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.z) matches configured target release for branch (4.5.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1822945 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1822945 targets the "4.6.0" release, which is one of the valid target releases: 4.6.0, 4.6.z
  • bug has dependents

In response to this:

[release-4.5] Bug 1855894: Add netns mount

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jul 28, 2020
@knobunc
Copy link
Contributor

knobunc commented Jul 29, 2020

/retest

2 similar comments
@knobunc
Copy link
Contributor

knobunc commented Jul 29, 2020

/retest

@knobunc
Copy link
Contributor

knobunc commented Jul 30, 2020

/retest

@knobunc
Copy link
Contributor

knobunc commented Jul 30, 2020

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 30, 2020
@knobunc
Copy link
Contributor

knobunc commented Jul 30, 2020

@juanluisvaladas you lgtmed the 4.4 backport of this (#731) can you approve this one too please?

@openshift-ci-robot openshift-ci-robot mentioned this pull request Jul 30, 2020
Merged
@pecameron
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 30, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knobunc, openshift-cherrypick-robot, pecameron

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knobunc knobunc added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jul 30, 2020
@knobunc
Copy link
Contributor

knobunc commented Jul 30, 2020 •
edited

@sdodson I added the cherry-pick-approved because this is needed to go in with openshift/machine-config-operator#1954 (and you already approved that one). Please yank it if you disagree.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 631bec3 into openshift:release-4.5 Jul 31, 2020
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: An error was encountered searching for bug 1855894 on the Bugzilla server at https://bugzilla.redhat.com:

Get https://bugzilla.redhat.com/rest/bug/1855894?api_key=CENSORED: dial tcp: lookup bugzilla.redhat.com on 172.30.0.10:53: no such host
Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

[release-4.5] Bug 1855894: Add netns mount

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knobunc
Copy link
Contributor

knobunc commented Jul 31, 2020

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@knobunc: All pull requests linked via external trackers have merged: openshift/machine-config-operator#1954, openshift/cluster-network-operator#730. Bugzilla bug 1855894 has been moved to the MODIFIED state.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danwinship danwinship Awaiting requested review from danwinship

@rcarrillocruz rcarrillocruz Awaiting requested review from rcarrillocruz

Assignees

@knobunc knobunc

@pecameron pecameron

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@openshift-cherrypick-robot @openshift-ci-robot @knobunc @pecameron @openshift-bot @openshift-merge-robot