Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure northd probe interval during startup #733

Merged
merged 1 commit into from Aug 1, 2020

Conversation

abhat
Copy link
Contributor

@abhat abhat commented Jul 30, 2020

This commit adds support for configuring the ovn northd probe interval
in the start-up script for the nbdb container.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 30, 2020
@dcbw
Copy link
Contributor

dcbw commented Jul 30, 2020

@abhat needs some testcase updates to fix test/unit job.

@abhat
Copy link
Contributor Author

abhat commented Jul 30, 2020

/test images

@abhat
Copy link
Contributor Author

abhat commented Jul 30, 2020

/test e2e-gcp-upgrade

@abhat
Copy link
Contributor Author

abhat commented Jul 30, 2020

/test e2e-gcp-ovn

@abhat
Copy link
Contributor Author

abhat commented Jul 30, 2020

@abhat
Copy link
Contributor Author

abhat commented Jul 30, 2020

/test e2e-gcp-upgrade

This commit adds support for configuring the ovn northd probe interval
in the start-up script for the nbdb container.
@abhat
Copy link
Contributor Author

abhat commented Jul 30, 2020

/test images

@trozet
Copy link
Contributor

trozet commented Jul 31, 2020

gcp-ovn-upgrade is actually using openshift-sdn....

@trozet
Copy link
Contributor

trozet commented Jul 31, 2020

it looks like the error is gone from the logs
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhat, trozet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@dcbw
Copy link
Contributor

dcbw commented Jul 31, 2020

this PR has no effect on SDN
/override e2e-aws-sdn-single

@openshift-ci-robot
Copy link
Contributor

@dcbw: /override requires a failed status context to operate on.
The following unknown contexts were given:

  • e2e-aws-sdn-single

Only the following contexts were expected:

  • ci/prow/e2e-aws-sdn-multi
  • ci/prow/e2e-aws-sdn-single
  • ci/prow/e2e-azure
  • ci/prow/e2e-gcp
  • ci/prow/e2e-gcp-ovn
  • ci/prow/e2e-gcp-ovn-upgrade
  • ci/prow/e2e-gcp-upgrade
  • ci/prow/e2e-metal-ipi
  • ci/prow/e2e-openstack
  • ci/prow/e2e-ovn-hybrid-step-registry
  • ci/prow/e2e-ovn-step-registry
  • ci/prow/e2e-vsphere
  • ci/prow/e2e-windows-hybrid-network
  • ci/prow/images
  • ci/prow/unit
  • ci/prow/verify
  • tide

In response to this:

this PR has no effect on SDN
/override e2e-aws-sdn-single

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dcbw
Copy link
Contributor

dcbw commented Jul 31, 2020

/override ci/prow/e2e-aws-sdn-single

@openshift-ci-robot
Copy link
Contributor

@dcbw: Overrode contexts on behalf of dcbw: ci/prow/e2e-aws-sdn-single

In response to this:

/override ci/prow/e2e-aws-sdn-single

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dcbw
Copy link
Contributor

dcbw commented Jul 31, 2020

/test e2e-gcp-ovn

@dcbw
Copy link
Contributor

dcbw commented Jul 31, 2020

This PR is unrelated to SDN
/override ci/prow/e2e-aws-sdn-single

@openshift-ci-robot
Copy link
Contributor

@dcbw: Overrode contexts on behalf of dcbw: ci/prow/e2e-aws-sdn-single

In response to this:

This PR is unrelated to SDN
/override ci/prow/e2e-aws-sdn-single

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dcbw
Copy link
Contributor

dcbw commented Jul 31, 2020

gcp-ovn failure is know flake to be skipped by openshift/origin#25356
/override ci/prow/e2e-gcp-ovn

@openshift-ci-robot
Copy link
Contributor

@dcbw: Overrode contexts on behalf of dcbw: ci/prow/e2e-gcp-ovn

In response to this:

gcp-ovn failure is know flake to be skipped by openshift/origin#25356
/override ci/prow/e2e-gcp-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@abhat
Copy link
Contributor Author

abhat commented Jul 31, 2020

/test e2e-aws-sdn-single
/test e2e-gcp-ovn
/test e2e-gcp-upgrade
/test e2e-aws-sdn-multi

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 1, 2020

@abhat: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-sdn-single 1c34b9b link /test e2e-aws-sdn-single
ci/prow/e2e-openstack 1c34b9b link /test e2e-openstack

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit e015923 into openshift:master Aug 1, 2020
@abhat abhat deleted the add_probe_interval branch August 5, 2020 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants