New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1867538: Kuryr: Update KuryrPort CRD to move vifs to status #759
Bug 1867538: Kuryr: Update KuryrPort CRD to move vifs to status #759
Conversation
The vifs field totally belongs to the status part of the KuryrPort CR and this commit moves it there. This is handled in kuryr-kubernetes too. Should be safe as version with previous CRD wasn't yet released.
@dulek: This pull request references Bugzilla bug 1867538, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
1 similar comment
/retest |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dulek, MaysaMacedo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@dulek: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@dulek: All pull requests linked via external trackers have merged: openshift/kuryr-kubernetes#324, openshift/cluster-network-operator#759. Bugzilla bug 1867538 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The vifs field totally belongs to the status part of the KuryrPort CR
and this commit moves it there. This is handled in kuryr-kubernetes too.
Should be safe as version with previous CRD wasn't yet released.