Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1874457: Ensure router is present when Kuryr is used #770

Merged
merged 1 commit into from Sep 16, 2020
Merged

Bug 1874457: Ensure router is present when Kuryr is used #770

merged 1 commit into from Sep 16, 2020

Conversation

MaysaMacedo
Copy link
Contributor

Kuryr requires a router to be present on the cluster
to allow communication between Pod and Services. However,
during a FIP less no router is created by the installer.
This commit makes sure a router is created if not already
present.

@MaysaMacedo
Copy link
Contributor Author

/hold

Still needs to be tested.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 31, 2020
@MaysaMacedo MaysaMacedo force-pushed the create-router-when-missing branch 2 times, most recently from 7ca8b10 to da2f5ba Compare September 1, 2020 11:43
@MaysaMacedo MaysaMacedo changed the title Ensure router is present when Kuryr is used Bug 1874457: Ensure router is present when Kuryr is used Sep 1, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Sep 1, 2020
@openshift-ci-robot
Copy link
Contributor

@MaysaMacedo: This pull request references Bugzilla bug 1874457, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1874457: Ensure router is present when Kuryr is used

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot mentioned this pull request Sep 3, 2020
Merged
@MaysaMacedo MaysaMacedo force-pushed the create-router-when-missing branch 3 times, most recently from 2f297ab to b27bc62 Compare September 10, 2020 07:48
@luis5tb
Copy link
Contributor

luis5tb commented Sep 11, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 11, 2020
dulek
dulek suggested changes Sep 11, 2020
View reviewed changes
Copy link
Contributor

@dulek dulek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small improvement that can be made.

pkg/platform/openstack/networking.go Outdated Show resolved Hide resolved
@luis5tb
Copy link
Contributor

luis5tb commented Sep 11, 2020

/retest

@luis5tb
Copy link
Contributor

luis5tb commented Sep 11, 2020

/approve

@MaysaMacedo
Ensure router is present when Kuryr is used
058ed69 
Kuryr requires a router to be present on the cluster
to allow communication between VMs, Pod and Services.
However, during a FIP less no router is created by
the installer. This commit makes sure a router is
created if not already present.
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Sep 11, 2020
@dulek
Copy link
Contributor

dulek commented Sep 11, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 11, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

7 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@MaysaMacedo
Copy link
Contributor Author

/test e2e-operator-with-custom-vxlan-port

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

16 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 16, 2020 •
edited

@MaysaMacedo: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-operator-with-custom-vxlan-port 058ed69 link /test e2e-operator-with-custom-vxlan-port

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit b687150 into openshift:master Sep 16, 2020
@openshift-ci-robot
Copy link
Contributor

@MaysaMacedo: All pull requests linked via external trackers have merged:

Bugzilla bug 1874457 has been moved to the MODIFIED state.

In response to this:

Bug 1874457: Ensure router is present when Kuryr is used

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luis5tb luis5tb luis5tb left review comments

@dulek dulek dulek requested changes

@celebdor celebdor Awaiting requested review from celebdor

Assignees

@dulek dulek

@luis5tb luis5tb

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@MaysaMacedo @openshift-ci-robot @luis5tb @dulek @openshift-bot @openshift-merge-robot