New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1891023: Fix ovn rbac proxy init script secret name #841
Bug 1891023: Fix ovn rbac proxy init script secret name #841
Conversation
We were pointing to both wrong service name and namespace.
/assign @tssurya |
@@ -467,7 +467,7 @@ spec: | |||
echo $(date -Iseconds) INFO: Failed to get ovnkube-master service from API. Retry "${retries}"/100 1>&2 | |||
sleep 20 | |||
done | |||
if [ "${retries}" -ge 20 ]; then | |||
if [ "${retries}" -ge 100 ]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are we changing the retries from 20 to 100? In sdn we use 20. Anyways let's see, now that the namespace part is fixed we should not be hitting this that often.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because we retry 100 times:
while [[ "${retries}" -lt 100 ]]; do
This should have never been 20.
/retest |
/retest |
/retest |
/approve |
/retest |
/override e2e-aws-sdn-multi We're not modifying sdn at all. |
@juanluisvaladas: juanluisvaladas unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
@juanluisvaladas: This pull request references Bugzilla bug 1891023, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
/bugzilla refresh |
@juanluisvaladas: This pull request references Bugzilla bug 1891023, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@trozet: This pull request references Bugzilla bug 1891023, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/override e2e-agnostic-upgrade |
/override ci/prow/e2e-aws-sdn-multi |
@trozet: /override requires a failed status context to operate on.
Only the following contexts were expected:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@trozet: Overrode contexts on behalf of trozet: ci/prow/e2e-aws-sdn-multi In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/override ci/prow/e2e-agnostic-upgrade |
@trozet: Overrode contexts on behalf of trozet: ci/prow/e2e-agnostic-upgrade In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dcbw, juanluisvaladas, squeed, trozet, tssurya The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@juanluisvaladas: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/override ci/prow/e2e-aws-sdn-multi |
@trozet: Overrode contexts on behalf of trozet: ci/prow/e2e-aws-sdn-multi In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@juanluisvaladas: All pull requests linked via external trackers have merged: Bugzilla bug 1891023 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
We were pointing to both wrong service name and namespace.