Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1891023: Fix ovn rbac proxy init script secret name #841

Conversation

juanluisvaladas
Copy link
Contributor

We were pointing to both wrong service name and namespace.

We were pointing to both wrong service name and namespace.
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 19, 2020
@juanluisvaladas
Copy link
Contributor Author

/assign @tssurya

@@ -467,7 +467,7 @@ spec:
echo $(date -Iseconds) INFO: Failed to get ovnkube-master service from API. Retry "${retries}"/100 1>&2
sleep 20
done
if [ "${retries}" -ge 20 ]; then
if [ "${retries}" -ge 100 ]; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are we changing the retries from 20 to 100? In sdn we use 20. Anyways let's see, now that the namespace part is fixed we should not be hitting this that often.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because we retry 100 times:
while [[ "${retries}" -lt 100 ]]; do

This should have never been 20.

@tssurya
Copy link
Contributor

tssurya commented Oct 19, 2020

/retest

@juanluisvaladas
Copy link
Contributor Author

/retest
/retitle Fix ovn rbac proxy init script secret name
Verified that this is working as intended

@openshift-ci-robot openshift-ci-robot changed the title [WIP]Fix ovn rbac proxy init script secret name Fix ovn rbac proxy init script secret name Oct 19, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 19, 2020
@juanluisvaladas
Copy link
Contributor Author

/retest

@squeed
Copy link
Contributor

squeed commented Oct 21, 2020

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 21, 2020
@juanluisvaladas
Copy link
Contributor Author

/retest

@juanluisvaladas
Copy link
Contributor Author

/override e2e-aws-sdn-multi

We're not modifying sdn at all.

@openshift-ci-robot
Copy link
Contributor

@juanluisvaladas: juanluisvaladas unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file.

In response to this:

/override e2e-aws-sdn-multi

We're not modifying sdn at all.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@juanluisvaladas
Copy link
Contributor Author

/retest

@juanluisvaladas juanluisvaladas changed the title Fix ovn rbac proxy init script secret name Bug 1891023: Fix ovn rbac proxy init script secret name Oct 23, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Oct 23, 2020
@openshift-ci-robot
Copy link
Contributor

@juanluisvaladas: This pull request references Bugzilla bug 1891023, which is invalid:

  • expected the bug to target the "4.7.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1891023: Fix ovn rbac proxy init script secret name

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Oct 23, 2020
@tssurya
Copy link
Contributor

tssurya commented Oct 23, 2020

/lgtm

@juanluisvaladas
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@juanluisvaladas: This pull request references Bugzilla bug 1891023, which is invalid:

  • expected the bug to target the "4.7.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 23, 2020
@trozet
Copy link
Contributor

trozet commented Oct 23, 2020

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Oct 23, 2020
@openshift-ci-robot
Copy link
Contributor

@trozet: This pull request references Bugzilla bug 1891023, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Oct 23, 2020
@trozet
Copy link
Contributor

trozet commented Oct 23, 2020

/override e2e-agnostic-upgrade

@trozet
Copy link
Contributor

trozet commented Oct 23, 2020

/override ci/prow/e2e-aws-sdn-multi

@openshift-ci-robot
Copy link
Contributor

@trozet: /override requires a failed status context to operate on.
The following unknown contexts were given:

  • e2e-agnostic-upgrade

Only the following contexts were expected:

  • ci/prow/e2e-agnostic-upgrade
  • ci/prow/e2e-aws-ovn-windows
  • ci/prow/e2e-aws-ovn-windows-custom-vxlan
  • ci/prow/e2e-aws-sdn-multi
  • ci/prow/e2e-aws-sdn-single
  • ci/prow/e2e-azure-ovn
  • ci/prow/e2e-gcp
  • ci/prow/e2e-gcp-ovn
  • ci/prow/e2e-gcp-ovn-upgrade
  • ci/prow/e2e-metal-ipi-ovn-ipv6
  • ci/prow/e2e-openstack-ovn
  • ci/prow/e2e-ovn-hybrid-step-registry
  • ci/prow/e2e-ovn-step-registry
  • ci/prow/e2e-upgrade
  • ci/prow/e2e-vsphere-ovn
  • ci/prow/images
  • ci/prow/unit
  • ci/prow/verify
  • tide

In response to this:

/override e2e-agnostic-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

@trozet: Overrode contexts on behalf of trozet: ci/prow/e2e-aws-sdn-multi

In response to this:

/override ci/prow/e2e-aws-sdn-multi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@trozet
Copy link
Contributor

trozet commented Oct 23, 2020

/override ci/prow/e2e-agnostic-upgrade

@openshift-ci-robot
Copy link
Contributor

@trozet: Overrode contexts on behalf of trozet: ci/prow/e2e-agnostic-upgrade

In response to this:

/override ci/prow/e2e-agnostic-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@trozet
Copy link
Contributor

trozet commented Oct 23, 2020

/lgtm

@dcbw
Copy link
Contributor

dcbw commented Oct 23, 2020

/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dcbw, juanluisvaladas, squeed, trozet, tssurya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Oct 23, 2020

@juanluisvaladas: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-sdn-single e9dda38 link /test e2e-aws-sdn-single

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@trozet
Copy link
Contributor

trozet commented Oct 23, 2020

/override ci/prow/e2e-aws-sdn-multi

@openshift-ci-robot
Copy link
Contributor

@trozet: Overrode contexts on behalf of trozet: ci/prow/e2e-aws-sdn-multi

In response to this:

/override ci/prow/e2e-aws-sdn-multi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 6373fd4 into openshift:master Oct 23, 2020
@openshift-ci-robot
Copy link
Contributor

@juanluisvaladas: All pull requests linked via external trackers have merged:

Bugzilla bug 1891023 has been moved to the MODIFIED state.

In response to this:

Bug 1891023: Fix ovn rbac proxy init script secret name

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants