Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow DefaultNetwork.Type to have arbitrary values. #86

Merged
merged 1 commit into from
Feb 7, 2019
Merged

Allow DefaultNetwork.Type to have arbitrary values. #86

merged 1 commit into from
Feb 7, 2019

Conversation

squeed
Copy link
Contributor

@squeed squeed commented Feb 1, 2019

The intention is for users of third-party network plugins to still be able to set their network type.

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 1, 2019
danwinship
danwinship reviewed Feb 1, 2019
View reviewed changes
pkg/network/render_test.go Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@openshift-merge-robot
Copy link
Contributor

/retest

1 similar comment
@openshift-merge-robot
Copy link
Contributor

/retest

@squeed
Allow DefaultNetwork.Type to have arbitrary values.
87b47ae 
The intention is for users of third-party network plugins to still be
able to set their network type.
@squeed
Copy link
Contributor Author

squeed commented Feb 7, 2019

OK, updated. @danwinship, PTAL.

@danwinship
Copy link
Contributor

Should we try to do something about the case where they specify OpenShiftSND or OpenshiftSDN or (everyone's favorite typo) OpenShitSDN? Maybe add a Message to the Available operator status clarifying that the operator doesn't recognize the plugin name and so hasn't deployed a plugin?

@squeed
Copy link
Contributor Author

squeed commented Feb 7, 2019

Oh, that's a very good point - we should definitely add a message to the Status field.

@danwinship
Copy link
Contributor

/lgtm
Casey is going to add another card about having a clear status here

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 7, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danwinship, squeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit c226dca into openshift:master Feb 7, 2019
@squeed squeed deleted the allow-unknown branch February 13, 2019 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danwinship danwinship danwinship left review comments

@dcbw dcbw Awaiting requested review from dcbw

@JacobTanenbaum JacobTanenbaum Awaiting requested review from JacobTanenbaum

Assignees

@danwinship danwinship

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@squeed @openshift-merge-robot @danwinship @openshift-ci-robot