New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify kube-rbac-proxy startup script #879
Simplify kube-rbac-proxy startup script #879
Conversation
CNO tries to create the objects defined in bindata's files in lexicographic order, so we can rely on the secret being created when this starts. I don't know what happens if during an upgrade the CNO fails to create the services, so it's probably a good idea not to backport this to 4.6.
/retest |
AIUI, the Secret isn't created by the CNO, it's created by the service-cert controller. So we can't actually rely on it existing. If you wanted to create an empty secret, that might work. I believe the mount would be automatically updated when the serving certs are created. |
@squeed We wait for the cert to be mounted later: cluster-network-operator/bindata/network/openshift-sdn/sdn.yaml Lines 209 to 212 in cea0ebf
|
Oh duh. /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: juanluisvaladas, squeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
5 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
@juanluisvaladas: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
CNO tries to create the objects defined in bindata's files in
lexicographic order, so we can rely on the secret being created when
this starts.
I don't know what happens if during an upgrade the CNO
fails to create the services, so it's probably a good idea not to
backport this to 4.6.
/assign @tssurya