Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify kube-rbac-proxy startup script #879

Merged

Conversation

juanluisvaladas
Copy link
Contributor

CNO tries to create the objects defined in bindata's files in
lexicographic order, so we can rely on the secret being created when
this starts.

I don't know what happens if during an upgrade the CNO
fails to create the services, so it's probably a good idea not to
backport this to 4.6.

/assign @tssurya

CNO tries to create the objects defined in bindata's files in
lexicographic order, so we can rely on the secret being created when
this starts.

I don't know what happens if during an upgrade the CNO
fails to create the services, so it's probably a good idea not to
backport this to 4.6.
@juanluisvaladas
Copy link
Contributor Author

/retest

@squeed
Copy link
Contributor

squeed commented Nov 16, 2020

AIUI, the Secret isn't created by the CNO, it's created by the service-cert controller. So we can't actually rely on it existing.

If you wanted to create an empty secret, that might work. I believe the mount would be automatically updated when the serving certs are created.

@juanluisvaladas
Copy link
Contributor Author

juanluisvaladas commented Nov 17, 2020

@squeed We wait for the cert to be mounted later:

while [[ ! -f "${TLS_PK}" || ! -f "${TLS_CERT}" ]] ; do
log_missing_certs
sleep 5
done

@squeed
Copy link
Contributor

squeed commented Nov 18, 2020

Oh duh.

/approve
/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juanluisvaladas, squeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 18, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Nov 18, 2020

@juanluisvaladas: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-vsphere-ovn cea0ebf link /test e2e-vsphere-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants