Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.6] Bug 1901605: Kuryr: Allow changes to KuryrConfig #890

Merged
merged 1 commit into from Jan 28, 2021
Merged

[release-4.6] Bug 1901605: Kuryr: Allow changes to KuryrConfig #890

merged 1 commit into from Jan 28, 2021

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #883

/assign dulek

@dulek
Kuryr: Allow changes to KuryrConfig
7c3ac25 
With the fact that change in the kuryr-config ConfigMap will trigger
recreation of all Kuryr pods, we can allow changing Kuryr options on the
running cluster. This commit implements that making sure that only
options directly affecting only kuryr.conf are considered safe to
apply.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 25, 2020
Merged
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Bugzilla bug 1901604 has been cloned as Bugzilla bug 1901605. Retitling PR to link against new bug.
/retitle [release-4.6] Bug 1901605: Kuryr: Allow changes to KuryrConfig

In response to this:

[release-4.6] Bug 1901604: Kuryr: Allow changes to KuryrConfig

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot changed the title [release-4.6] Bug 1901604: Kuryr: Allow changes to KuryrConfig [release-4.6] Bug 1901605: Kuryr: Allow changes to KuryrConfig Nov 25, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Nov 25, 2020
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1901605, which is invalid:

  • expected dependent Bugzilla bug 1901604 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is MODIFIED instead
  • expected dependent Bugzilla bug 1901604 to target a release in 4.7.0, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.6] Bug 1901605: Kuryr: Allow changes to KuryrConfig

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Nov 25, 2020
@dulek
Copy link
Contributor

dulek commented Nov 25, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 25, 2020
@dulek
Copy link
Contributor

dulek commented Nov 25, 2020

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@dulek: This pull request references Bugzilla bug 1901605, which is invalid:

  • expected dependent Bugzilla bug 1901604 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is MODIFIED instead
  • expected dependent Bugzilla bug 1901604 to target a release in 4.7.0, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dulek
Copy link
Contributor

dulek commented Nov 25, 2020

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@dulek: This pull request references Bugzilla bug 1901605, which is invalid:

  • expected dependent Bugzilla bug 1901604 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

@openshift-ci-robot
Copy link
Contributor

@openshift-bot: This pull request references Bugzilla bug 1901605, which is invalid:

  • expected dependent Bugzilla bug 1901604 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dulek
Copy link
Contributor

dulek commented Nov 26, 2020

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Nov 26, 2020
@openshift-ci-robot
Copy link
Contributor

@dulek: This pull request references Bugzilla bug 1901605, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.z) matches configured target release for branch (4.6.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1901604 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1901604 targets the "4.7.0" release, which is one of the valid target releases: 4.7.0
  • bug has dependents

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Nov 26, 2020
@dulek
Copy link
Contributor

dulek commented Nov 26, 2020

/retest

4 similar comments
@dulek
Copy link
Contributor

dulek commented Nov 27, 2020

/retest

@luis5tb
Copy link
Contributor

luis5tb commented Dec 1, 2020

/retest

@dulek
Copy link
Contributor

dulek commented Dec 1, 2020

/retest

@luis5tb
Copy link
Contributor

luis5tb commented Dec 17, 2020

/retest

@openshift-merge-robot
Copy link
Contributor

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-ovn-step-registry 7c3ac25 link /test e2e-ovn-step-registry
ci/prow/e2e-vsphere-ovn 7c3ac25 link /test e2e-vsphere-ovn
ci/prow/e2e-gcp 7c3ac25 link /test e2e-gcp
ci/prow/e2e-azure-ovn 7c3ac25 link /test e2e-azure-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@luis5tb
Copy link
Contributor

luis5tb commented Jan 7, 2021

/retest

1 similar comment
@dulek
Copy link
Contributor

dulek commented Jan 13, 2021

/retest

@dulek
Copy link
Contributor

dulek commented Jan 13, 2021

@squeed: Can you take a look? I don't think I can approve this backport on my own.

@squeed
Copy link
Contributor

squeed commented Jan 13, 2021

sure can.
/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dulek, openshift-cherrypick-robot, squeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 13, 2021
@dulek
Copy link
Contributor

dulek commented Jan 13, 2021

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@jwforres jwforres added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jan 27, 2021
@dulek
Copy link
Contributor

dulek commented Jan 28, 2021

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 3fbeb75 into openshift:release-4.6 Jan 28, 2021
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 1901605 has been moved to the MODIFIED state.

In response to this:

[release-4.6] Bug 1901605: Kuryr: Allow changes to KuryrConfig

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squeed squeed Awaiting requested review from squeed

@trozet trozet Awaiting requested review from trozet

Assignees

@dulek dulek

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@openshift-cherrypick-robot @openshift-ci-robot @dulek @openshift-bot @luis5tb @openshift-merge-robot @squeed @jwforres