Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1906650: Add NetworkPolicy, EgressIP, and EgressFirewall to related-objects #919

Merged
merged 1 commit into from Jan 4, 2021
Merged

Bug 1906650: Add NetworkPolicy, EgressIP, and EgressFirewall to related-objects #919

merged 1 commit into from Jan 4, 2021

Conversation

astoycos
Copy link
Contributor

@astoycos astoycos commented Dec 16, 2020 •
edited

This PR adds the NetworkPolicy, EgressIP, and EgressFirewall to the CNO's related object list so they are collected across the entire cluster when a must-gather is run.

The Egress IPs are collected under cluster-scoped-resources

The NetworyPolicies and EgressFirewall's are collected on a per namespace basis

@astoycos
Add more related objects to the CNO
3234ad2 
Add Network Policy, EgressFirewall and EgressIP
objects to the CNO's related object list so they
collected when an `oc adm inspect <object>` or
`oc adm must-gather` is run

Signed-off-by: Andrew Stoycos <astoycos@redhat.com>
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Dec 16, 2020
@openshift-ci-robot
Copy link
Contributor

@astoycos: This pull request references Bugzilla bug 1906650, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1906650: Add NetworkPolicy, EgressIP, and EgressFirewall to related-objects

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

@astoycos: This pull request references Bugzilla bug 1906650, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1906650: Add NetworkPolicy, EgressIP, and EgressFirewall to related-objects

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@astoycos
Copy link
Contributor Author

/retest

@juanluisvaladas
Copy link
Contributor

/hold
As we mentioned in the private conversation, we don't know if this might cause some problems with must-gather on openshift-sdn. So holding it until it's tested
Other than that seems fine to me.
/lgtm

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 16, 2020
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 16, 2020
@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Dec 16, 2020 •
edited

@astoycos: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-ovn-windows-custom-vxlan 3234ad2 link /test e2e-aws-ovn-windows-custom-vxlan
ci/prow/e2e-aws-ovn-windows 3234ad2 link /test e2e-aws-ovn-windows
ci/prow/e2e-azure-ovn 3234ad2 link /test e2e-azure-ovn
ci/prow/e2e-ovn-hybrid-step-registry 3234ad2 link /test e2e-ovn-hybrid-step-registry
ci/prow/e2e-ovn-ipsec-step-registry 3234ad2 link /test e2e-ovn-ipsec-step-registry

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@astoycos
Copy link
Contributor Author

astoycos commented Dec 17, 2020 •
edited by openshift-ci-robot

Verified on 4.7 SDN + OVN-K clusters, does not break must gather, in SDN case EgressFirewall and EgressIP objects are just skipped

[must-gather-l6fk8] POD     [skipping gathering podnetworkconnectivitychecks.controlplane.operator.openshift.io due to error: the server doesn't have a resource type "podnetworkconnectivitychecks", skipping gathering EgressFirewall.k8s.ovn.org due to error: the server doesn't have a resource type "EgressFirewall", skipping gathering EgressIP.k8s.ovn.org due to error: the server doesn't have a resource type "EgressIP", skipping gathering endpoints/host-[etcd-2](https://issues.redhat.com/browse/etcd-2) due to error: endpoints "host-[etcd-2](https://issues.redhat.com/browse/etcd-2)" not found, skipping gathering namespaces/openshift-manila-csi-driver due to error: namespaces "openshift-manila-csi-driver" not found, skipping gathering clustercsidrivers.operator.openshift.io/cinder.csi.openstack.org due to error: clustercsidrivers.operator.openshift.io "cinder.csi.openstack.org" not found, skipping gathering clustercsidrivers.operator.openshift.io/pd.csi.storage.gke.io due to error: clustercsidrivers.operator.openshift.io "pd.csi.storage.gke.io" not found, skipping gathering clustercsidrivers.operator.openshift.io/csi.ovirt.org due to error: clustercsidrivers.operator.openshift.io "csi.ovirt.org" not found, skipping gathering clustercsidrivers.operator.openshift.io/manila.csi.openstack.org due to error: clustercsidrivers.operator.openshift.io "manila.csi.openstack.org" not found]

@astoycos
Copy link
Contributor Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 17, 2020
@astoycos
Copy link
Contributor Author

/assign @rcarrillocruz

@astoycos
Copy link
Contributor Author

/retest

1 similar comment
@astoycos
Copy link
Contributor Author

astoycos commented Jan 4, 2021

/retest

@rcarrillocruz
Copy link
Contributor

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: astoycos, juanluisvaladas, rcarrillocruz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 4, 2021
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 4, 2021 •
edited

@astoycos: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-azure-ovn 3234ad2 link /test e2e-azure-ovn
ci/prow/e2e-ovn-ipsec-step-registry 3234ad2 link /test e2e-ovn-ipsec-step-registry
ci/prow/e2e-ovn-hybrid-step-registry 3234ad2 link /test e2e-ovn-hybrid-step-registry
ci/prow/e2e-aws-ovn-windows-custom-vxlan 3234ad2 link /test e2e-aws-ovn-windows-custom-vxlan
ci/prow/e2e-aws-ovn-windows 3234ad2 link /test e2e-aws-ovn-windows

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 5372b4f into openshift:master Jan 4, 2021
@openshift-ci-robot
Copy link
Contributor

@astoycos: All pull requests linked via external trackers have merged:

Bugzilla bug 1906650 has been moved to the MODIFIED state.

In response to this:

Bug 1906650: Add NetworkPolicy, EgressIP, and EgressFirewall to related-objects

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aojea aojea Awaiting requested review from aojea

@juanluisvaladas juanluisvaladas Awaiting requested review from juanluisvaladas

Assignees

@rcarrillocruz rcarrillocruz

@juanluisvaladas juanluisvaladas

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@astoycos @openshift-ci-robot @juanluisvaladas @openshift-merge-robot @rcarrillocruz @openshift-bot