Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1914402: ipsec: Add liveness probe #952

Conversation

markdgray
Copy link
Contributor

In the case of failure of ipsec daemons, add liveness
probe to detect so that the kubelet can restart the
container.

Signed-off-by: Mark Gray mark.d.gray@redhat.com

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jan 13, 2021
@markdgray
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@markdgray: This pull request references Bugzilla bug 1914402, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1914402: ipsec: Add liveness probe

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

@markdgray: This pull request references Bugzilla bug 1914402, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@markdgray markdgray force-pushed the fix/add_ipsec_liveness_probe/1914402 branch 2 times, most recently from 0fd4078 to b0bded8 Compare January 14, 2021 19:59
@markdgray
Copy link
Contributor Author

ipsec is failing with some kind of aws quota

/retest

@markdgray
Copy link
Contributor Author

markdgray commented Jan 15, 2021

unrelated panic in ipsec case

/retest

In the case of failure of ipsec daemons, add liveness
probe to detect so that the kubelet can restart the
container.

Signed-off-by: Mark Gray <mark.d.gray@redhat.com>
Currently, the readiness probe only checks for failures of
the 'ovs-monitor-ipsec' daemon.

Signed-off-by: Mark Gray <mark.d.gray@redhat.com>
@markdgray markdgray force-pushed the fix/add_ipsec_liveness_probe/1914402 branch 2 times, most recently from 6537df1 to 353a902 Compare January 19, 2021 14:16
@astoycos
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 19, 2021
@markdgray
Copy link
Contributor Author

unrelated panic in pods/openshift-operator-lifecycle-manager_packageserver for ipsec job

/retest

@markdgray
Copy link
Contributor Author

ipsec: looks unrelated. machine config operator and one worker node was not ready.

/test e2e-ovn-ipsec-step-registry

@markdgray
Copy link
Contributor Author

ipsec has passed. As this PR is only for the case when IPsec is enabled. Any other failures are unrelated.

/retest

1 similar comment
@markdgray
Copy link
Contributor Author

ipsec has passed. As this PR is only for the case when IPsec is enabled. Any other failures are unrelated.

/retest

@dcbw
Copy link
Contributor

dcbw commented Jan 20, 2021

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: astoycos, dcbw, markdgray

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 20, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 20, 2021

@markdgray: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-openstack-ovn 353a902 link /test e2e-openstack-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit c6a7d45 into openshift:master Jan 21, 2021
@openshift-ci-robot
Copy link
Contributor

@markdgray: All pull requests linked via external trackers have merged:

Bugzilla bug 1914402 has been moved to the MODIFIED state.

In response to this:

Bug 1914402: ipsec: Add liveness probe

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@markdgray markdgray deleted the fix/add_ipsec_liveness_probe/1914402 branch February 9, 2021 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants