Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor fixups to docs/operands.md #958

Merged
merged 1 commit into from Jan 25, 2021
Merged

Minor fixups to docs/operands.md #958

merged 1 commit into from Jan 25, 2021

Conversation

danwinship
Copy link
Contributor

(mostly because I noticed that the indentation was wrong in the sections that were supposed to be <pre>)

@danwinship
Minor fixups to docs/operands.md
c8d5e59 
Fix some wording.
Fix some markdown.
Ensure that the string "multus-admission-controller" appears at least
once with the expected capitalization.
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danwinship

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 25, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 25, 2021 •
edited

@danwinship: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-vsphere-ovn c8d5e59 link /test e2e-vsphere-ovn
ci/prow/e2e-openstack-ovn c8d5e59 link /test e2e-openstack-ovn
ci/prow/e2e-ovn-ipsec-step-registry c8d5e59 link /test e2e-ovn-ipsec-step-registry

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@danwinship
Copy link
Contributor Author

docs-only fix

/override ci/prow/e2e-agnostic-upgrade
/override ci/prow/e2e-gcp
/override ci/prow/e2e-gcp-ovn

@openshift-ci-robot
Copy link
Contributor

@danwinship: Overrode contexts on behalf of danwinship: ci/prow/e2e-agnostic-upgrade, ci/prow/e2e-gcp, ci/prow/e2e-gcp-ovn

In response to this:

docs-only fix

/override ci/prow/e2e-agnostic-upgrade
/override ci/prow/e2e-gcp
/override ci/prow/e2e-gcp-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@danwinship danwinship merged commit d1e4955 into openshift:master Jan 25, 2021
@danwinship danwinship deleted the operand-doc-fixup branch January 25, 2021 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trozet trozet Awaiting requested review from trozet

@tssurya tssurya Awaiting requested review from tssurya

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danwinship @openshift-ci-robot