New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1920769: override the default node-selector for network-connectivity check #965
Bug 1920769: override the default node-selector for network-connectivity check #965
Conversation
If the default node selector is not overridden then during upgrade the network never comes up because the network diagnostics assumes the network-checker pods are on all nodes and if the default node selector is present and not overridden it could be restricted.
@JacobTanenbaum: This pull request references Bugzilla bug 1920769, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@JacobTanenbaum: This pull request references Bugzilla bug 1920769, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
waiting for CI to pass before doing a LGTM. can you also link to a cluster-bot upgrade job here if that makes sense? |
@JacobTanenbaum: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/test e2e-gcp-ovn-upgrade |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhat, JacobTanenbaum The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@JacobTanenbaum: All pull requests linked via external trackers have merged: Bugzilla bug 1920769 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
If the default node selector is not overridden then during upgrade the
network never comes up because the network diagnostics assumes the
network-checker pods are on all nodes and if the default node selector
is present and not overridden they could be restricted.