Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1920769: override the default node-selector for network-connectivity check #965

Merged
merged 1 commit into from Feb 2, 2021

Conversation

JacobTanenbaum
Copy link
Contributor

If the default node selector is not overridden then during upgrade the
network never comes up because the network diagnostics assumes the
network-checker pods are on all nodes and if the default node selector
is present and not overridden they could be restricted.

If the default node selector is not overridden then during upgrade the
network never comes up because the network diagnostics assumes the
network-checker pods are on all nodes and if the default node selector
is present and not overridden it could be restricted.
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Feb 1, 2021
@openshift-ci-robot
Copy link
Contributor

@JacobTanenbaum: This pull request references Bugzilla bug 1920769, which is invalid:

  • expected the bug to target the "4.7.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1920769: override the default node-selector for network-connectivity check

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Feb 1, 2021
@JacobTanenbaum
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Feb 1, 2021
@openshift-ci-robot
Copy link
Contributor

@JacobTanenbaum: This pull request references Bugzilla bug 1920769, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Feb 1, 2021
@abhat
Copy link
Contributor

abhat commented Feb 1, 2021

waiting for CI to pass before doing a LGTM. can you also link to a cluster-bot upgrade job here if that makes sense?

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 2, 2021

@JacobTanenbaum: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-vsphere-ovn cc38b95 link /test e2e-vsphere-ovn
ci/prow/e2e-gcp-ovn-upgrade cc38b95 link /test e2e-gcp-ovn-upgrade
ci/prow/e2e-openstack-ovn cc38b95 link /test e2e-openstack-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@abhat
Copy link
Contributor

abhat commented Feb 2, 2021

/test e2e-gcp-ovn-upgrade
/test e2e-vsphere-ovn

@abhat
Copy link
Contributor

abhat commented Feb 2, 2021

/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhat, JacobTanenbaum

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 2, 2021
@openshift-merge-robot openshift-merge-robot merged commit 2db7f9b into openshift:master Feb 2, 2021
@openshift-ci-robot
Copy link
Contributor

@JacobTanenbaum: All pull requests linked via external trackers have merged:

Bugzilla bug 1920769 has been moved to the MODIFIED state.

In response to this:

Bug 1920769: override the default node-selector for network-connectivity check

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants