cmd: stop using URL_ONLY_KUBECONFIG #976
Conversation
openshift-ci-robot
added
the
approved
Previously, we used to parse the kubelet's kubeconfig to get the URL to the apiserver. But this is a strange coupling. In openshift/machine-config-operator#2232 we added a special environment file that emulates the in-cluster config environment variables. So now we can just source that if it exists. Keep the old code for now, mostly out of paranoia for upgrade / downgrade issues.
|
Test failures are uninteresting; the cluster came up just fine. Rebased (though not needed), hopefully we go green soon. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dcbw, squeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
4 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@squeed: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Previously, we used to parse the kubelet's kubeconfig to get the URL to the apiserver. But this is a strange coupling.
In openshift/machine-config-operator#2232 we added a special environment file that emulates the in-cluster config environment variables. So now we can just source that if it exists.
Fallback to the old mode for now, mostly out of paranoia for upgrade / downgrade.