Bug 1928028: Kuryr: Let Kuryr autodetect primary CNI interface #978
Conversation
Kuryr has a mechanism in place that attempts to autodetect the primary trunk interface that the kuryr-cni should bind the subports to. The mechanism checks if the interface that's configured as link_iface exists and if not attempts to do autodetection by looking where kubelet's bound. We hardcoded `link_iface=ens3` in the config anyway, assuming that if in some configurations interface is named differently we'll just do the autodetection. The problem with that approach is when there are multiple interfaces and they're swapped, we'll just keep using the wrong one never attempting autodetection. And we were told that this sometimes happens. This patch removes the [binding]link_iface from the kuryr.conf in order to always force the autodetection and make sure kuryr-cni will bind fine even if interface order is reversed.
|
@openshift-cherrypick-robot: Bugzilla bug 1921184 has been cloned as Bugzilla bug 1928028. Retitling PR to link against new bug. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
changed the title
openshift-ci-robot
added
bugzilla/severity-medium
|
@openshift-cherrypick-robot: This pull request references Bugzilla bug 1928028, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
@dulek: This pull request references Bugzilla bug 1928028, which is valid. 6 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (gcheresh@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
removed
the
bugzilla/invalid-bug
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dulek, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
crawford
changed the title
crawford
added
the
cherry-pick-approved
|
/retest |
|
@openshift-cherrypick-robot: All pull requests linked via external trackers have merged: Bugzilla bug 1928028 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.6 Apparently this seems to be a bigger issue in 4.6. |
|
@dulek: new pull request created: #1035 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is an automated cherry-pick of #969
/assign luis5tb