Removing old kuryr-kubernetes CRDs #989
Conversation
openshift-ci-robot
added
the
needs-ok-to-test
|
Hi @scavnicka. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
scavnicka
force-pushed
the
remove_old_crd
branch
from
096a7c5
to
1ca5f8f
Compare
|
/ok-to-test |
openshift-ci-robot
added
ok-to-test
|
/lgtm Seems good to me, we should probably test this a bit on a live setup. |
openshift-ci-robot
added
lgtm
|
Seems like you need to update the tests too: https://github.com/openshift/cluster-network-operator/blob/master/pkg/network/kuryr_test.go#L70. I'd just update it to check for all the CRDs that still exist. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/lgtm cancel |
openshift-ci-robot
removed
lgtm
|
/hold Holding it from merging, just so that we can test it. |
openshift-ci-robot
added
the
do-not-merge/hold
|
Could you squash all the commits into the first commit "Removing old kuryr-kubernetes CRDs"? |
scavnicka
force-pushed
the
remove_old_crd
branch
2 times, most recently
from
7b158d8
to
ef68ccf
Compare
When moving from annotation to CRD, old CRDs was left to allow user to upgrade from 4.5 to 4.6 version. Now we are going to upgrade to ocp 4.8, so everyone should already use CRD instead of annotations and we can remove the old CRDs, which was used when we have worked with annotations.
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
It worked fine. |
|
/approve |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
28 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
When moving from annotation to CRD, old CRDs was left to allow user to upgrade from 4.5 to 4.6 version. Now we are going to upgrade to ocp 4.8, so everyone should already use CRD instead of annotations and we can remove the old CRDs, which was used when we have worked with annotations.