Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make variables declaration consistent across Makefile #64

Closed
ArangoGutierrez opened this issue Feb 13, 2020 · 0 comments · Fixed by #65
Closed

Make variables declaration consistent across Makefile #64

ArangoGutierrez opened this issue Feb 13, 2020 · 0 comments · Fixed by #65

Comments

@ArangoGutierrez
Copy link
Contributor

#58 (review)

We should make variables ${} vs. $() consistent across the Makefile. Traditionally, $() were mostly used to be used in GNU Makefiles and it still seems to be a preferred way to ${}. On the other hand BSD seem to prefer ${}. The choice is ours, but let's be consistent.
@ArangoGutierrez ArangoGutierrez changed the title Make variables decalration consistent across Makefile Make variables declaration consistent across Makefile Feb 13, 2020
ArangoGutierrez added a commit to ArangoGutierrez/cluster-nfd-operator that referenced this issue Feb 13, 2020
@ArangoGutierrez
Fix Makefile variables declaration
9773170 
Closes openshift#64

Signed-off-by: Carlos Eduardo Arango Gutierrez <carangog@redhat.com>
@ArangoGutierrez ArangoGutierrez mentioned this issue Feb 13, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Makefile variables declaration ArangoGutierrez/cluster-nfd-operator
1 participant
@ArangoGutierrez