Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.13] OCPBUGS-10702: Fixing Topology DS pods startup #315

Closed
wants to merge 1 commit into from
Closed

[release-4.13] OCPBUGS-10702: Fixing Topology DS pods startup #315

wants to merge 1 commit into from

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #314

/assign yevgeny-shnaidman

@yevgeny-shnaidman
Fixing Topology DS pods startup
a0e8320 
Fixes:
1) removing server argument - no longer needed or supported
2) changing kubelet-config-file argument to kubelet-config-uri and define scheme as file
3) fix topology CRD - add alpha2 version support
4) removing duplicate ServiceMonitor from release manifests
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 21, 2023
Merged
@openshift-ci openshift-ci bot requested review from bthurber and chr15p March 21, 2023 08:48
@ybettan
Copy link
Contributor

ybettan commented Mar 21, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 21, 2023
@ybettan
Copy link
Contributor

ybettan commented Mar 21, 2023

/assign @chr15p

@chr15p
Copy link
Contributor

chr15p commented Mar 21, 2023

/lgtm

@chr15p
Copy link
Contributor

chr15p commented Mar 21, 2023

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chr15p, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 21, 2023
@yevgeny-shnaidman
Copy link
Contributor

/test e2e-aws

2 similar comments
@yevgeny-shnaidman
Copy link
Contributor

/test e2e-aws

@yevgeny-shnaidman
Copy link
Contributor

/test e2e-aws

@yevgeny-shnaidman
Copy link
Contributor

/backport-risk-assessed

@yevgeny-shnaidman
Copy link
Contributor

/cherry-pick-approved

@yevgeny-shnaidman
Copy link
Contributor

/label backport-risk-assessed

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 22, 2023

@yevgeny-shnaidman: Can not set label backport-risk-assessed: Must be member in one of these teams: [openshift-patch-managers]

In response to this:

/label backport-risk-assessed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yevgeny-shnaidman
Copy link
Contributor

/retitle [release-4.13] OCPBUGS-10700: Fixing Topology DS pods startup

@openshift-ci openshift-ci bot changed the title [release-4.13] Fixing Topology DS pods startup [release-4.13] OCPBUGS-10700: Fixing Topology DS pods startup Mar 22, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 22, 2023

@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.13] OCPBUGS-10700: Fixing Topology DS pods startup

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 22, 2023
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-10700, which is invalid:

  • expected Jira Issue OCPBUGS-10700 to depend on a bug targeting a version in 4.14.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #314

/assign yevgeny-shnaidman

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yevgeny-shnaidman
Copy link
Contributor

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@yevgeny-shnaidman: This pull request references Jira Issue OCPBUGS-10700, which is invalid:

  • expected Jira Issue OCPBUGS-10700 to depend on a bug targeting a version in 4.14.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yevgeny-shnaidman
Copy link
Contributor

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@yevgeny-shnaidman: This pull request references Jira Issue OCPBUGS-10700, which is invalid:

  • expected the bug to target only the "4.13.0" version, but multiple target versions were set
  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead
  • expected Jira Issue OCPBUGS-10700 to depend on a bug targeting a version in 4.14.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yevgeny-shnaidman
Copy link
Contributor

/retitle [release-4.13] OCPBUGS-10702: Fixing Topology DS pods startup

@openshift-ci openshift-ci bot changed the title [release-4.13] OCPBUGS-10700: Fixing Topology DS pods startup [release-4.13] OCPBUGS-10702: Fixing Topology DS pods startup Mar 22, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 22, 2023

@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.13] OCPBUGS-10702: Fixing Topology DS pods startup

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 22, 2023
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-10702, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.0) matches configured target version for branch (4.13.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-10700 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-10700 targets the "4.14.0" version, which is one of the valid target versions: 4.14.0
  • bug has dependents

Requesting review from QA contact:
/cc @wabouhamad

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #314

/assign yevgeny-shnaidman

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yevgeny-shnaidman
Copy link
Contributor

/jira refresh

@openshift-ci openshift-ci bot requested a review from wabouhamad March 22, 2023 13:06
@openshift-ci-robot
Copy link
Contributor

@yevgeny-shnaidman: This pull request references Jira Issue OCPBUGS-10702, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.0) matches configured target version for branch (4.13.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-10700 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-10700 targets the "4.14.0" version, which is one of the valid target versions: 4.14.0
  • bug has dependents

Requesting review from QA contact:
/cc @wabouhamad

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wabouhamad
Copy link

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 22, 2023
@bthurber
Copy link

/label backport-risk-assessed

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 22, 2023

@bthurber: Can not set label backport-risk-assessed: Must be member in one of these teams: [openshift-patch-managers]

In response to this:

/label backport-risk-assessed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mrunalp mrunalp added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Mar 23, 2023
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 23, 2023
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 23, 2023

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ci-index a0e8320 link unknown /test ci-index
ci/prow/e2e-aws a0e8320 link unknown /test e2e-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot openshift-ci-robot mentioned this pull request Mar 27, 2023
Merged
@yevgeny-shnaidman
Copy link
Contributor

/close

@openshift-ci openshift-ci bot closed this Mar 27, 2023
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-10702. The bug has been updated to no longer refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #314

/assign yevgeny-shnaidman

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 27, 2023

@yevgeny-shnaidman: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bthurber bthurber Awaiting requested review from bthurber

@chr15p chr15p Awaiting requested review from chr15p

@wabouhamad wabouhamad Awaiting requested review from wabouhamad

Assignees

@chr15p chr15p

@ybettan ybettan

@yevgeny-shnaidman yevgeny-shnaidman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@openshift-cherrypick-robot @ybettan @chr15p @yevgeny-shnaidman @openshift-ci-robot @wabouhamad @bthurber @openshift-merge-robot @mrunalp