-
Notifications
You must be signed in to change notification settings - Fork 104
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
e2e: set performance profile cpus using env vars
We've been observing lately that some tests that involve disabling load balancing are failing (like 32646) because the expected result does not have specific anticipated CPUs. After investigation, it turns out that one factor is the profile configuration of the CPU distribution. PAO functional tests configure fixed CPU values under the PP. This is considered misconfiguration, especially when the system has more than 4 CPUs, and there is no guarantee that the functionality of the performance profile controller will work adequately with not all cpus reflected in the CPU section in the PP. To resolve this complication, we are introducing new environment variables RESERVED_CPU_SET, ISOLATED_CPU_SET, OFFLINED_CPU_SET, should be set the profile would use them instead of the defaults.
- Loading branch information
Showing
3 changed files
with
136 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,100 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <testsuites tests="4" disabled="0" errors="0" failures="1" time="0.318217729"> | ||
| <testsuite name="Performance Addon Operator configuration" package="/home/shajmakh/cluster-node-tuning-operator/test/e2e/performanceprofile/functests/0_config" tests="4" disabled="0" skipped="0" errors="0" failures="1" time="0.318217729" timestamp="2024-01-09T13:54:53"> | ||
| <properties> | ||
| <property name="SuiteSucceeded" value="false"></property> | ||
| <property name="SuiteHasProgrammaticFocus" value="false"></property> | ||
| <property name="SpecialSuiteFailureReason" value=""></property> | ||
| <property name="SuiteLabels" value="[]"></property> | ||
| <property name="RandomSeed" value="1704801291"></property> | ||
| <property name="RandomizeAllSpecs" value="false"></property> | ||
| <property name="LabelFilter" value=""></property> | ||
| <property name="FocusStrings" value=""></property> | ||
| <property name="SkipStrings" value=""></property> | ||
| <property name="FocusFiles" value=""></property> | ||
| <property name="SkipFiles" value=""></property> | ||
| <property name="FailOnPending" value="false"></property> | ||
| <property name="FailFast" value="true"></property> | ||
| <property name="FlakeAttempts" value="2"></property> | ||
| <property name="DryRun" value="false"></property> | ||
| <property name="ParallelTotal" value="1"></property> | ||
| <property name="OutputInterceptorMode" value=""></property> | ||
| </properties> | ||
| <testcase name="[BeforeSuite]" classname="Performance Addon Operator configuration" status="passed" time="6.7445e-05"> | ||
| <system-err>> Enter [BeforeSuite] TOP-LEVEL - /home/shajmakh/cluster-node-tuning-operator/test/e2e/performanceprofile/functests/0_config/test_suite_performance_config_test.go:54 @ 01/09/24 13:54:53.467
< Exit [BeforeSuite] TOP-LEVEL - /home/shajmakh/cluster-node-tuning-operator/test/e2e/performanceprofile/functests/0_config/test_suite_performance_config_test.go:54 @ 01/09/24 13:54:53.467 (0s)
</system-err> | ||
| </testcase> | ||
| <testcase name="[It] [performance][config] Performance configuration should remove OLM artifacts for performance-addon-operator" classname="Performance Addon Operator configuration" status="passed" time="0.292315322"> | ||
| <system-err>> Enter [BeforeEach] [performance][config] Performance configuration - /home/shajmakh/cluster-node-tuning-operator/test/e2e/performanceprofile/functests/utils/utils.go:24 @ 01/09/24 13:54:53.467
< Exit [BeforeEach] [performance][config] Performance configuration - /home/shajmakh/cluster-node-tuning-operator/test/e2e/performanceprofile/functests/utils/utils.go:24 @ 01/09/24 13:54:53.646 (179ms)
> Enter [It] should remove OLM artifacts for performance-addon-operator - /home/shajmakh/cluster-node-tuning-operator/test/e2e/performanceprofile/functests/0_config/config.go:49 @ 01/09/24 13:54:53.646
< Exit [It] should remove OLM artifacts for performance-addon-operator - /home/shajmakh/cluster-node-tuning-operator/test/e2e/performanceprofile/functests/0_config/config.go:49 @ 01/09/24 13:54:53.76 (114ms)
</system-err> | ||
| </testcase> | ||
| <testcase name="[It] [performance][config] Performance configuration Should successfully deploy the performance profile" classname="Performance Addon Operator configuration" status="failed" time="0.002254741"> | ||
| <failure message="failed to build performance profile: both reserved and isolated cpusets are required.
Unexpected error:
 <*errors.errorString | 0xc89d3f8>: 
 both reserved and isolated cpusets are required.
 {
 s: "both reserved and isolated cpusets are required.",
 }
occurred" type="failed">[FAILED] failed to build performance profile: both reserved and isolated cpusets are required.
Unexpected error:
 <*errors.errorString | 0xc89d3f8>: 
 both reserved and isolated cpusets are required.
 {
 s: "both reserved and isolated cpusets are required.",
 }
occurred
In [It] at: /home/shajmakh/cluster-node-tuning-operator/test/e2e/performanceprofile/functests/0_config/config.go:70 @ 01/09/24 13:54:53.784

There were additional failures detected after the initial failure. These are visible in the timeline
</failure> | ||
| <system-err>> Enter [BeforeEach] [performance][config] Performance configuration - /home/shajmakh/cluster-node-tuning-operator/test/e2e/performanceprofile/functests/utils/utils.go:24 @ 01/09/24 13:54:53.782
< Exit [BeforeEach] [performance][config] Performance configuration - /home/shajmakh/cluster-node-tuning-operator/test/e2e/performanceprofile/functests/utils/utils.go:24 @ 01/09/24 13:54:53.782 (0s)
> Enter [It] Should successfully deploy the performance profile - /home/shajmakh/cluster-node-tuning-operator/test/e2e/performanceprofile/functests/0_config/config.go:67 @ 01/09/24 13:54:53.782
[FAILED] Failure recorded during attempt 1:
failed to build performance profile: both reserved and isolated cpusets are required.
Unexpected error:
 <*errors.errorString | 0xc452058>: 
 both reserved and isolated cpusets are required.
 {
 s: "both reserved and isolated cpusets are required.",
 }
occurred
In [It] at: /home/shajmakh/cluster-node-tuning-operator/test/e2e/performanceprofile/functests/0_config/config.go:70 @ 01/09/24 13:54:53.783
< Exit [It] Should successfully deploy the performance profile - /home/shajmakh/cluster-node-tuning-operator/test/e2e/performanceprofile/functests/0_config/config.go:67 @ 01/09/24 13:54:53.783 (1ms)

Attempt #1 Failed. Retrying ↺ @ 01/09/24 13:54:53.783

> Enter [BeforeEach] [performance][config] Performance configuration - /home/shajmakh/cluster-node-tuning-operator/test/e2e/performanceprofile/functests/utils/utils.go:24 @ 01/09/24 13:54:53.783
< Exit [BeforeEach] [performance][config] Performance configuration - /home/shajmakh/cluster-node-tuning-operator/test/e2e/performanceprofile/functests/utils/utils.go:24 @ 01/09/24 13:54:53.783 (0s)
> Enter [It] Should successfully deploy the performance profile - /home/shajmakh/cluster-node-tuning-operator/test/e2e/performanceprofile/functests/0_config/config.go:67 @ 01/09/24 13:54:53.783
[FAILED] failed to build performance profile: both reserved and isolated cpusets are required.
Unexpected error:
 <*errors.errorString | 0xc89d3f8>: 
 both reserved and isolated cpusets are required.
 {
 s: "both reserved and isolated cpusets are required.",
 }
occurred
In [It] at: /home/shajmakh/cluster-node-tuning-operator/test/e2e/performanceprofile/functests/0_config/config.go:70 @ 01/09/24 13:54:53.784
< Exit [It] Should successfully deploy the performance profile - /home/shajmakh/cluster-node-tuning-operator/test/e2e/performanceprofile/functests/0_config/config.go:67 @ 01/09/24 13:54:53.784 (1ms)
</system-err> | ||
| </testcase> | ||
| <testcase name="[ReportAfterSuite] e2e serial suite" classname="Performance Addon Operator configuration" status="passed" time="5.0296e-05"> | ||
| <system-err>> Enter [ReportAfterSuite] TOP-LEVEL - /home/shajmakh/cluster-node-tuning-operator/test/e2e/performanceprofile/functests/0_config/test_suite_performance_config_test.go:59 @ 01/09/24 13:54:53.793
< Exit [ReportAfterSuite] TOP-LEVEL - /home/shajmakh/cluster-node-tuning-operator/test/e2e/performanceprofile/functests/0_config/test_suite_performance_config_test.go:59 @ 01/09/24 13:54:53.793 (0s)
</system-err> | ||
| </testcase> | ||
| </testsuite> | ||
| <testsuite name="" package="/home/shajmakh/cluster-node-tuning-operator/test/e2e/performanceprofile/functests/1_performance" tests="0" disabled="0" skipped="0" errors="0" failures="0" time="0" timestamp="0001-01-01T00:00:00"> | ||
| <properties> | ||
| <property name="SuiteSucceeded" value="false"></property> | ||
| <property name="SuiteHasProgrammaticFocus" value="false"></property> | ||
| <property name="SpecialSuiteFailureReason" value="Suite did not run because prior suites failed and --keep-going is not set"></property> | ||
| <property name="SuiteLabels" value="[]"></property> | ||
| <property name="RandomSeed" value="1704801291"></property> | ||
| <property name="RandomizeAllSpecs" value="false"></property> | ||
| <property name="LabelFilter" value=""></property> | ||
| <property name="FocusStrings" value=""></property> | ||
| <property name="SkipStrings" value=""></property> | ||
| <property name="FocusFiles" value=""></property> | ||
| <property name="SkipFiles" value=""></property> | ||
| <property name="FailOnPending" value="false"></property> | ||
| <property name="FailFast" value="true"></property> | ||
| <property name="FlakeAttempts" value="2"></property> | ||
| <property name="DryRun" value="false"></property> | ||
| <property name="ParallelTotal" value="1"></property> | ||
| <property name="OutputInterceptorMode" value=""></property> | ||
| </properties> | ||
| </testsuite> | ||
| <testsuite name="" package="/home/shajmakh/cluster-node-tuning-operator/test/e2e/performanceprofile/functests/6_mustgather_testing" tests="0" disabled="0" skipped="0" errors="0" failures="0" time="0" timestamp="0001-01-01T00:00:00"> | ||
| <properties> | ||
| <property name="SuiteSucceeded" value="false"></property> | ||
| <property name="SuiteHasProgrammaticFocus" value="false"></property> | ||
| <property name="SpecialSuiteFailureReason" value="Suite did not run because prior suites failed and --keep-going is not set"></property> | ||
| <property name="SuiteLabels" value="[]"></property> | ||
| <property name="RandomSeed" value="1704801291"></property> | ||
| <property name="RandomizeAllSpecs" value="false"></property> | ||
| <property name="LabelFilter" value=""></property> | ||
| <property name="FocusStrings" value=""></property> | ||
| <property name="SkipStrings" value=""></property> | ||
| <property name="FocusFiles" value=""></property> | ||
| <property name="SkipFiles" value=""></property> | ||
| <property name="FailOnPending" value="false"></property> | ||
| <property name="FailFast" value="true"></property> | ||
| <property name="FlakeAttempts" value="2"></property> | ||
| <property name="DryRun" value="false"></property> | ||
| <property name="ParallelTotal" value="1"></property> | ||
| <property name="OutputInterceptorMode" value=""></property> | ||
| </properties> | ||
| </testsuite> | ||
| <testsuite name="" package="/home/shajmakh/cluster-node-tuning-operator/test/e2e/performanceprofile/functests/10_performance_ppc" tests="0" disabled="0" skipped="0" errors="0" failures="0" time="0" timestamp="0001-01-01T00:00:00"> | ||
| <properties> | ||
| <property name="SuiteSucceeded" value="false"></property> | ||
| <property name="SuiteHasProgrammaticFocus" value="false"></property> | ||
| <property name="SpecialSuiteFailureReason" value="Suite did not run because prior suites failed and --keep-going is not set"></property> | ||
| <property name="SuiteLabels" value="[]"></property> | ||
| <property name="RandomSeed" value="1704801291"></property> | ||
| <property name="RandomizeAllSpecs" value="false"></property> | ||
| <property name="LabelFilter" value=""></property> | ||
| <property name="FocusStrings" value=""></property> | ||
| <property name="SkipStrings" value=""></property> | ||
| <property name="FocusFiles" value=""></property> | ||
| <property name="SkipFiles" value=""></property> | ||
| <property name="FailOnPending" value="false"></property> | ||
| <property name="FailFast" value="true"></property> | ||
| <property name="FlakeAttempts" value="2"></property> | ||
| <property name="DryRun" value="false"></property> | ||
| <property name="ParallelTotal" value="1"></property> | ||
| <property name="OutputInterceptorMode" value=""></property> | ||
| </properties> | ||
| </testsuite> | ||
| </testsuites> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters