Render: Do not fail if there is no recommended profile.

Signed-off-by: Jose Luis Ojosnegros Manchón <jojosneg@redhat.com>

pkg/tuned/cmd/render/render.go

@@ -128,7 +128,6 @@ func render(inputDir []string, outputDir string, mcpName string) error {
 			}
 		}
 	}
-
 	// Append any missing default manifests (i.e. `master`/`worker`)
 	mcPools = util.AppendMissingDefaultMCPManifests(mcPools)
 
@@ -160,17 +159,18 @@ func render(inputDir []string, outputDir string, mcpName string) error {
 		tuneD = append(tuneD, tunedFromPP)
 	}
 
+	recommendedProfile := ""
 	tuneDrecommended := operator.TunedRecommend(tuneD)
-	if len(tuneDrecommended) == 0 {
-		klog.Error("Unable to get tuned recommended profile.")
-		return fmt.Errorf("Unable to get tuned recommended profile.")
-	}
+	if len(tuneDrecommended) > 0 {
+		recommendedProfile = *tuneDrecommended[0].Profile
+		klog.Infof("RecommendedProfile found :%s", recommendedProfile)
 
-	recommendedProfile := *tuneDrecommended[0].Profile
-	err = tunedpkg.TunedRecommendFileWrite(recommendedProfile)
-	if err != nil {
-		klog.Errorf("error writing recommended profile %q : %v", recommendedProfile, err)
-		return fmt.Errorf("error writing recommended profile %q : %w", recommendedProfile, err)
+		err = tunedpkg.TunedRecommendFileWrite(recommendedProfile)
+		if err != nil {
+			klog.Warningf("error writing recommended profile %q : %v", recommendedProfile, err)
+		}
+	} else {
+		klog.Info("Unable to get tuned recommended profile.")
 	}
 
 	t := manifests.TunedRenderedResource(tuneD)
@@ -195,7 +195,7 @@ func render(inputDir []string, outputDir string, mcpName string) error {
 		return err
 	}
 
-	mc, err := renderMachineConfig(mcp, bootcmdline, mcConfigs, tuneDrecommended[0].MachineConfigLabels)
+	mc, err := renderMachineConfig(mcp, bootcmdline, mcConfigs, mcp.Spec.MachineConfigSelector.MatchLabels)
 	if err != nil {
 		klog.Errorf("error while rendering machine config  %v", err)
 		return fmt.Errorf("error while rendering machine config: %w", err)
@@ -209,7 +209,7 @@ func render(inputDir []string, outputDir string, mcpName string) error {
 			return err
 		}
 
-		fileName := fmt.Sprintf("%s_%s_kargs.yaml", recommendedProfile, strings.ToLower(mc.Kind))
+		fileName := fmt.Sprintf("%s_%s_kargs.yaml", "kernelcmdargs", strings.ToLower(mc.Kind))
 		fullFilePath := filepath.Join(outputDir, fileName)
 		klog.Info("Writing file: ", fullFilePath)
 		err = os.WriteFile(fullFilePath, byteOutput, 0644)

pkg/tuned/controller.go

@@ -377,10 +377,13 @@ func ProfilesExtract(profiles []tunedv1.TunedProfile, recommendedProfile string)
 	)
 	klog.Info("profilesExtract(): extracting TuneD profiles")
 
-	// Get a list of TuneD profiles names the recommended profile depends on.
-	recommendedProfileDeps := profileDepends(recommendedProfile)
-	// Add the recommended profile itself.
-	recommendedProfileDeps[recommendedProfile] = true
+	recommendedProfileDeps := map[string]bool{}
+	if len(recommendedProfile) > 0 {
+		// Get a list of TuneD profiles names the recommended profile depends on.
+		recommendedProfileDeps = profileDepends(recommendedProfile)
+		// Add the recommended profile itself.
+		recommendedProfileDeps[recommendedProfile] = true
+	}
 	extracted := map[string]bool{} // TuneD profile names present in TuneD CR and successfully extracted to /etc/tuned/<profile>/
 
 	for index, profile := range profiles {