OCPBUGS-31694: E2E: Workload hints test cases fixes #1012

mrniranjan · 2024-04-02T15:55:04Z

No description provided.

mrniranjan · 2024-04-03T01:23:44Z

/test e2e-gcp-pao-updating-profile

openshift-ci-robot · 2024-04-03T12:24:58Z

@mrniranjan: This pull request references Jira Issue OCPBUGS-31694, which is invalid:

expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

… stuck Signed-off-by: Niranjan M.R <mrniranjan@redhat.com>

mrniranjan · 2024-04-03T12:27:10Z

/jira refresh

openshift-ci-robot · 2024-04-03T12:27:16Z

@mrniranjan: This pull request references Jira Issue OCPBUGS-31694, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.16.0) matches configured target version for branch (4.16.0)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @gsr-shanks

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

ffromani

/approve

LGTM once a inline question is addressed

ffromani · 2024-04-05T07:08:44Z

test/e2e/performanceprofile/functests/8_performance_workloadhints/workloadhints.go

@@ -258,28 +259,32 @@ var _ = Describe("[rfe_id:49062][workloadHints] Telco friendly workload specific

 		When("realtime and high power consumption enabled", func() {
 			It("[test_id:50993][crit:high][vendor:cnf-qe@redhat.com][level:acceptance]should update kernel arguments and tuned accordingly", func() {
+				currentWorkloadHints := profile.Spec.WorkloadHints


do we need a DeepCopy() here?

You mean should we DeepCopy() ?

Here, i only intend to get the current profile before i modify, to check if the current profile is already contains the changes i intend to make further, if the current profile already contains the changes needed, then don't need to apply the spec changes , directly check the tuning parameters.

The reason we need this in Downstream we already have performance profile created before test runs and in the performance profile highPowerConsumption and realTime workload hints are already set to True, with this profile when this test runs, where we are setting these to true , the mcp is hung because there is nothing to change and test timesout waiting on mcp update.

this patch addresses this issue by getting the current workloadhints and if they are same skip the mcp update and test the tunings.

ffromani · 2024-04-05T07:08:51Z

test/e2e/performanceprofile/functests/8_performance_workloadhints/workloadhints.go

@@ -320,27 +325,29 @@ var _ = Describe("[rfe_id:49062][workloadHints] Telco friendly workload specific

 		When("perPodPowerManagent enabled", func() {
 			It("[test_id:54177]should update kernel arguments and tuned accordingly", func() {
+				currentWorkloadHints := profile.Spec.WorkloadHints


ditto: do we need a DeepCopy() here?

openshift-ci · 2024-04-05T07:09:56Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ffromani, mrniranjan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [ffromani]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Niranjan M.R <mrniranjan@redhat.com>

ffromani

/lgtm

openshift-ci · 2024-04-15T15:55:58Z

@mrniranjan: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci-robot · 2024-04-15T15:59:31Z

@mrniranjan: Jira Issue OCPBUGS-31694: All pull requests linked via external trackers have merged:

openshift/cluster-node-tuning-operator#1012

Jira Issue OCPBUGS-31694 has been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-bot · 2024-04-15T19:43:08Z

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-node-tuning-operator-container-v4.16.0-202404151450.p0.g0d90b86.assembly.stream.el9 for distgit cluster-node-tuning-operator.
All builds following this will include this PR.

openshift-merge-robot · 2024-04-16T08:29:43Z

Fix included in accepted release 4.16.0-0.nightly-2024-04-16-015315

mrniranjan · 2024-04-21T12:30:28Z

/cherry-pick release-4.15

openshift-cherrypick-robot · 2024-04-21T12:31:18Z

@mrniranjan: #1012 failed to apply on top of branch "release-4.15":

Applying: compare existing profile with changes being made to avoid mcp getting stuck
Using index info to reconstruct a base tree...
M	test/e2e/performanceprofile/functests/8_performance_workloadhints/workloadhints.go
Falling back to patching base and 3-way merge...
Auto-merging test/e2e/performanceprofile/functests/8_performance_workloadhints/workloadhints.go
Applying: Extend the comparing the of workloadhints to few more test cases
Using index info to reconstruct a base tree...
M	test/e2e/performanceprofile/functests/8_performance_workloadhints/workloadhints.go
Falling back to patching base and 3-way merge...
Auto-merging test/e2e/performanceprofile/functests/8_performance_workloadhints/workloadhints.go
CONFLICT (content): Merge conflict in test/e2e/performanceprofile/functests/8_performance_workloadhints/workloadhints.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0002 Extend the comparing the of workloadhints to few more test cases
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

* compare existing profile with changes being made to avoid mcp getting stuck Signed-off-by: Niranjan M.R <mrniranjan@redhat.com> * Extend the comparing the of workloadhints to few more test cases Signed-off-by: Niranjan M.R <mrniranjan@redhat.com> --------- Signed-off-by: Niranjan M.R <mrniranjan@redhat.com> Co-authored-by: Niranjan M.R <mrniranjan@redhat.com>

* compare existing profile with changes being made to avoid mcp getting stuck * Extend the comparing the of workloadhints to few more test cases --------- Signed-off-by: Niranjan M.R <mrniranjan@redhat.com> Co-authored-by: Niranjan M.R <mrniranjan@redhat.com>

openshift-ci bot requested review from rbaturov and swatisehgal April 2, 2024 16:01

mrniranjan changed the title ~~E2E: Workload hints test cases fixes~~ OCPBUGS-31694: E2E: Workload hints test cases fixes Apr 3, 2024

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 3, 2024

compare existing profile with changes being made to avoid mcp getting…

9f87013

… stuck Signed-off-by: Niranjan M.R <mrniranjan@redhat.com>

mrniranjan force-pushed the workloads_fix branch from ae68995 to 9f87013 Compare April 3, 2024 12:25

openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Apr 3, 2024

openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Apr 3, 2024

openshift-ci bot requested a review from gsr-shanks April 3, 2024 12:27

ffromani reviewed Apr 5, 2024

View reviewed changes

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 5, 2024

Extend the comparing the of workloadhints to few more test cases

c45491a

Signed-off-by: Niranjan M.R <mrniranjan@redhat.com>

ffromani reviewed Apr 15, 2024

View reviewed changes

openshift-ci bot assigned ffromani Apr 15, 2024

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 15, 2024

openshift-merge-bot bot merged commit 0d90b86 into openshift:master Apr 15, 2024
16 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

OCPBUGS-31694: E2E: Workload hints test cases fixes #1012

OCPBUGS-31694: E2E: Workload hints test cases fixes #1012

mrniranjan commented Apr 2, 2024

mrniranjan commented Apr 3, 2024

openshift-ci-robot commented Apr 3, 2024

mrniranjan commented Apr 3, 2024

openshift-ci-robot commented Apr 3, 2024

ffromani left a comment

ffromani Apr 5, 2024

mrniranjan Apr 5, 2024

mrniranjan Apr 5, 2024

mrniranjan Apr 5, 2024

ffromani Apr 5, 2024

openshift-ci bot commented Apr 5, 2024

ffromani left a comment

openshift-ci bot commented Apr 15, 2024

openshift-ci-robot commented Apr 15, 2024

openshift-bot commented Apr 15, 2024

openshift-merge-robot commented Apr 16, 2024

mrniranjan commented Apr 21, 2024

openshift-cherrypick-robot commented Apr 21, 2024

OCPBUGS-31694: E2E: Workload hints test cases fixes #1012

OCPBUGS-31694: E2E: Workload hints test cases fixes #1012

Conversation

mrniranjan commented Apr 2, 2024

mrniranjan commented Apr 3, 2024

openshift-ci-robot commented Apr 3, 2024

mrniranjan commented Apr 3, 2024

openshift-ci-robot commented Apr 3, 2024

ffromani left a comment

Choose a reason for hiding this comment

ffromani Apr 5, 2024

Choose a reason for hiding this comment

mrniranjan Apr 5, 2024

Choose a reason for hiding this comment

mrniranjan Apr 5, 2024

Choose a reason for hiding this comment

mrniranjan Apr 5, 2024

Choose a reason for hiding this comment

ffromani Apr 5, 2024

Choose a reason for hiding this comment

openshift-ci bot commented Apr 5, 2024

ffromani left a comment

Choose a reason for hiding this comment

openshift-ci bot commented Apr 15, 2024

openshift-ci-robot commented Apr 15, 2024

openshift-bot commented Apr 15, 2024

openshift-merge-robot commented Apr 16, 2024

mrniranjan commented Apr 21, 2024

openshift-cherrypick-robot commented Apr 21, 2024