Add preliminary support for the cpu-partitioning profile. #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
do-not-merge/work-in-progress
openshift-ci-robot
added
the
approved
|
/test e2e-aws |
sjug
reviewed
Jan 14, 2020
|
/lgtm |
Changes:
- allow patches to modify tuned profiles too (see rhbz#1781664)
- mount host directories to allow:
* persistent changes to /etc/sysconfig/irqbalance
* tuned to populate /etc/modprobe.d directory with module
options (see kvm.rt.tuned.conf)
* persistent changes to host's /etc/systemd/system.conf
by tuned setting CPUAffinity
- create /etc/grub.d/, /boot to make tuned's [bootloader] plugin
pass and generate /etc/tuned/bootcmdline
- include tuned patch for rhbz#1781664 (variable expansion)
- include tuned patch to enable multiple profile inheritance
(tuned 2.13 feature)
- include an example custom openshift-cpu-partitioning profile
Note that the [bootloader] plugin does not do any host modifications,
however, the variables in /etc/tuned/bootcmdline should be set
correctly.
jmencak
force-pushed
the
cpu-partitioning
branch
from
80eb9c5
to
64db45a
Compare
|
/lgtm Need more lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jmencak, sjug The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jmencak
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
|
/retest Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
options (see kvm.rt.tuned.conf)
by tuned setting CPUAffinity
pass and generate /etc/tuned/bootcmdline
(tuned 2.13 feature)
Note that the [bootloader] plugin does not do any host modifications,
however, the variables in /etc/tuned/bootcmdline should be set
correctly.