New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NO-JIRA: pao:controller: remove depracated function #1039
NO-JIRA: pao:controller: remove depracated function #1039
Conversation
`deleteDeprecatedComponents` function was added in older releases to overcome this issue: openshift-kni/performance-addon-operators#538 This is no longer relevant and can be removed since it was intented to fix an upgrade issue from an old version. Signed-off-by: Talor Itzhak <titzhak@redhat.com>
@Tal-or: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/approve I agree this function is both deprecated and can be removed |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ffromani, Tal-or The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
/retest |
1 similar comment
/retest |
@Tal-or: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
[ART PR BUILD NOTIFIER] This PR has been included in build cluster-node-tuning-operator-container-v4.16.0-202404181209.p0.g42972b5.assembly.stream.el9 for distgit cluster-node-tuning-operator. |
deleteDeprecatedComponents
function was added in older releases to overcome this issue:openshift-kni/performance-addon-operators#538
This is no longer relevant and can be removed since it was intented to fix an upgrade issue from an old version.