Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-JIRA: pao:controller: remove depracated function #1039

Merged
merged 1 commit into from Apr 17, 2024

Conversation

Tal-or
Copy link
Contributor

@Tal-or Tal-or commented Apr 17, 2024

deleteDeprecatedComponents function was added in older releases to overcome this issue:
openshift-kni/performance-addon-operators#538

This is no longer relevant and can be removed since it was intented to fix an upgrade issue from an old version.

`deleteDeprecatedComponents` function was added in older releases
to overcome this issue:
openshift-kni/performance-addon-operators#538

This is no longer relevant and can be removed since it was intented to fix
an upgrade issue from an old version.

Signed-off-by: Talor Itzhak <titzhak@redhat.com>
@openshift-ci-robot
Copy link
Contributor

@Tal-or: This pull request explicitly references no jira issue.

In response to this:

deleteDeprecatedComponents function was added in older releases to overcome this issue:
openshift-kni/performance-addon-operators#538

This is no longer relevant and can be removed since it was intented to fix an upgrade issue from an old version.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 17, 2024
@openshift-ci openshift-ci bot requested review from MarSik and yanirq April 17, 2024 12:25
@ffromani
Copy link
Contributor

/approve

I agree this function is both deprecated and can be removed

Copy link
Contributor

openshift-ci bot commented Apr 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ffromani, Tal-or

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 17, 2024
@yanirq
Copy link
Contributor

yanirq commented Apr 17, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 17, 2024
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 0751f57 and 2 for PR HEAD 7d940d7 in total

@Tal-or
Copy link
Contributor Author

Tal-or commented Apr 17, 2024

/retest

1 similar comment
@Tal-or
Copy link
Contributor Author

Tal-or commented Apr 17, 2024

/retest

Copy link
Contributor

openshift-ci bot commented Apr 17, 2024

@Tal-or: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 42972b5 into openshift:master Apr 17, 2024
16 checks passed
@Tal-or Tal-or deleted the remove_depraceted_code branch April 18, 2024 05:52
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-node-tuning-operator-container-v4.16.0-202404181209.p0.g42972b5.assembly.stream.el9 for distgit cluster-node-tuning-operator.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants