Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-JIRA: perfprof: e2e: account for node base load #1047

Merged

Conversation

shajmakh
Copy link
Contributor

Currently the test would fail when tested on machines with exactly isolated cpus equal to the requested cpus by the pod. This is because the worker nodes has already other pods running on them and thus they are using already a portion of the isolated cpus of the node. Scheduling a pod requesting all allocatable cpus would fail due to insufficient cpus on node.

Skip the test if the testing environment is not suitable for the test's requirements.

Currently the test would fail when tested on machines with exactly
isolated cpus equal to the requested cpus by the pod. This is because
the worker nodes has already other pods running on them and thus they
are using already a portion of the isolated cpus of the node. Scheduling
a pod requesting all allocatable cpus would fail due to insufficient
cpus on node.

Skip the test if the testing environment is not suitable for the test's
requirements.

Signed-off-by: Shereen Haj <shajmakh@redhat.com>
@shajmakh
Copy link
Contributor Author

blocking: openshift/release#47439

Copy link
Contributor

@MarSik MarSik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 26, 2024
Copy link
Contributor

openshift-ci bot commented Apr 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MarSik, shajmakh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 26, 2024
@shajmakh
Copy link
Contributor Author

/retest

@shajmakh shajmakh changed the title perfprof: e2e: account for node base load NO-JIRA: perfprof: e2e: account for node base load Apr 26, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 26, 2024
@openshift-ci-robot
Copy link
Contributor

@shajmakh: This pull request explicitly references no jira issue.

In response to this:

Currently the test would fail when tested on machines with exactly isolated cpus equal to the requested cpus by the pod. This is because the worker nodes has already other pods running on them and thus they are using already a portion of the isolated cpus of the node. Scheduling a pod requesting all allocatable cpus would fail due to insufficient cpus on node.

Skip the test if the testing environment is not suitable for the test's requirements.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@shajmakh
Copy link
Contributor Author

/retest

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD dd2698c and 2 for PR HEAD 21428e0 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD d55e5f6 and 1 for PR HEAD 21428e0 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 722642e and 0 for PR HEAD 21428e0 in total

Copy link
Contributor

openshift-ci bot commented Apr 28, 2024

@shajmakh: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 163236c into openshift:master Apr 28, 2024
16 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-node-tuning-operator-container-v4.16.0-202404291018.p0.g163236c.assembly.stream.el9 for distgit cluster-node-tuning-operator.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants