OCPBUGS-32980: [release-4.14]:fix extra-reboot on upgrade with paused mcp worker

[vitus133]

This PR fixes an extra-reboot when upgrading OpenShift with paused MCP "worker", for example during EUS-to-EUS upgrade. The extra-reboot occurred because PerformanceProfile controller was reconciling against rendered MC appearing in the MCP status. While this MC reflects current MCP conditions, it does not reflect the latest planned state when the MCP is paused.
Unpausing the MCP lead to one reboot when applying the target MC, and one additional reboot after the performance profile was reconciled against it.
This change eliminates this additional reboot because PerformanceProfile is now reconciling against the latest planned MC before the MCP is unpaused.
This is a manual cherry-pick from #1049
/cc @MarSik @yanirq

[openshift-ci-robot]

@vitus133: This pull request references Jira Issue OCPBUGS-32980, which is invalid:

• release note text must be set and not match the template OR release note type must be set to "Release Note Not Required"
• expected dependent Jira Issue OCPBUGS-32978 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This PR fixes an extra-reboot when upgrading OpenShift with paused MCP "worker", for example during EUS-to-EUS upgrade. The extra-reboot occurred because PerformanceProfile controller was reconciling against rendered MC appearing in the MCP status. While this MC reflects current MCP conditions, it does not reflect the latest planned state when the MCP is paused.
Unpausing the MCP lead to one reboot when applying the target MC, and one additional reboot after the performance profile was reconciled against it.
This change eliminates this additional reboot because PerformanceProfile is now reconciling against the latest planned MC before the MCP is unpaused.
This is a manual cherry-pick from #1049
/cc @MarSik @yanirq

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[vitus133]

/cc @mrniranjan

[vitus133]

/test e2e-upgrade

[mrniranjan]

/jira refresh

[openshift-ci-robot]

@mrniranjan: This pull request references Jira Issue OCPBUGS-32980, which is invalid:

• release note text must be set and not match the template OR release note type must be set to "Release Note Not Required"

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[yanirq]

/jira refresh

[openshift-ci-robot]

@yanirq: This pull request references Jira Issue OCPBUGS-32980, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.14.z) matches configured target version for branch (4.14.z)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
• release note text is set and does not match the template
• dependent bug Jira Issue OCPBUGS-32978 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
• dependent Jira Issue OCPBUGS-32978 targets the "4.15.z" version, which is one of the valid target versions: 4.15.0, 4.15.z
• bug has dependents

Requesting review from QA contact:
/cc @mrniranjan

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[yanirq]

/approve
/label backport-risk-assessed

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vitus133, yanirq

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [yanirq]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[yanirq]

/cc @mrniranjan

[mrniranjan]

/label cherry-pick-approved

[vitus133]

/test e2e-upgrade

[mrniranjan]

/test e2e-upgrade

[openshift-ci]

@vitus133: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[yanirq]

/lgtm

[openshift-ci-robot]

@vitus133: Jira Issue OCPBUGS-32980: All pull requests linked via external trackers have merged:

• openshift/cluster-node-tuning-operator#1053

Jira Issue OCPBUGS-32980 has been moved to the MODIFIED state.

In response to this:

This PR fixes an extra-reboot when upgrading OpenShift with paused MCP "worker", for example during EUS-to-EUS upgrade. The extra-reboot occurred because PerformanceProfile controller was reconciling against rendered MC appearing in the MCP status. While this MC reflects current MCP conditions, it does not reflect the latest planned state when the MCP is paused.
Unpausing the MCP lead to one reboot when applying the target MC, and one additional reboot after the performance profile was reconciled against it.
This change eliminates this additional reboot because PerformanceProfile is now reconciling against the latest planned MC before the MCP is unpaused.
This is a manual cherry-pick from #1049
/cc @MarSik @yanirq

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-node-tuning-operator-container-v4.14.0-202405081737.p0.gd969426.assembly.stream.el9 for distgit cluster-node-tuning-operator.
All builds following this will include this PR.