Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old ConfigMaps during upgrade from 4.[1-3] installations. #106

Merged
merged 1 commit into from Jan 29, 2020

Conversation

jmencak
Copy link
Contributor

@jmencak jmencak commented Jan 27, 2020

No description provided.

@jmencak jmencak requested a review from sjug January 27, 2020 19:55
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 27, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 27, 2020
@jmencak
Copy link
Contributor Author

jmencak commented Jan 28, 2020

/retest

@jmencak
Copy link
Contributor Author

jmencak commented Jan 28, 2020

/uncc @cep235

@openshift-ci-robot openshift-ci-robot removed the request for review from courtneypacheco January 28, 2020 13:39
@sjug
Copy link
Contributor

sjug commented Jan 29, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 29, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmencak, sjug

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 3098993 into openshift:master Jan 29, 2020
@jmencak jmencak deleted the 4.4-rm-old-cm branch January 29, 2020 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants