Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding "vet" target to Makefile. #107

Merged
merged 1 commit into from Jan 29, 2020
Merged

Adding "vet" target to Makefile. #107

merged 1 commit into from Jan 29, 2020

Conversation

jmencak
Copy link
Contributor

@jmencak jmencak commented Jan 28, 2020 •
edited

Added "vet" target to Makefile and fixed vet-reported issue.
Fixed -version reporting for openshift-tuned.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 28, 2020
@jmencak jmencak requested a review from sjug January 28, 2020 13:37
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 28, 2020
@jmencak
Copy link
Contributor Author

jmencak commented Jan 28, 2020

/uncc @Deepthidharwar

@openshift-ci-robot openshift-ci-robot removed the request for review from Deepthidharwar January 28, 2020 13:42
@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 28, 2020
@jmencak
Copy link
Contributor Author

jmencak commented Jan 28, 2020

/test e2e-aws-upgrade

@jmencak
Copy link
Contributor Author

jmencak commented Jan 28, 2020

/cc @skordas , fixing version reporting for openshift-tuned here. Thx for the report.

@jmencak
Adding "vet" target to Makefile.
6a89751 
Added "vet" target to Makefile and fixed vet-reported issue.
Fixed -version reporting for openshift-tuned.
sjug
sjug approved these changes Jan 29, 2020
View reviewed changes
Copy link
Contributor

@sjug sjug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 29, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmencak, sjug

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jmencak
Copy link
Contributor Author

jmencak commented Jan 29, 2020

/test e2e-aws

1 similar comment
@jmencak
Copy link
Contributor Author

jmencak commented Jan 29, 2020

/test e2e-aws

@openshift-merge-robot openshift-merge-robot merged commit b103959 into openshift:master Jan 29, 2020
@jmencak jmencak deleted the 4.4-make-vet branch January 30, 2020 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjug sjug sjug approved these changes

@zvonkok zvonkok Awaiting requested review from zvonkok

Assignees

@sjug sjug

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jmencak @openshift-ci-robot @sjug @openshift-merge-robot