Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1795671: Do not set owner references on tuned ServiceAccount (4.2) #109

Merged
merged 1 commit into from Mar 12, 2020
Merged

Bug 1795671: Do not set owner references on tuned ServiceAccount (4.2) #109

merged 1 commit into from Mar 12, 2020

Conversation

sjug
Copy link
Contributor

@sjug sjug commented Jan 28, 2020 •
edited

Fixes bug 1795671 which causes race conditions on upgrade from 4.x -> 4.2.

This PR removes owner reference from the ServiceAccount.

@sjug
Do not set owner references on tuned ServiceAccount
78d06c5 
Do not set owner references on tuned ServiceAccount to the default
Tuned custom resource.  Setting the references can result in unwanted
race conditions if/when the k8s garbage collection is slower than
startup of a newly created tuned DaemonSet and Pods it manages.
@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jan 28, 2020
@openshift-ci-robot
Copy link
Contributor

@sjug: This pull request references Bugzilla bug 1795671, which is invalid:

  • expected dependent Bugzilla bug 1795665 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1795671: Do not set owner references on tuned ServiceAccount (4.2)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sjug sjug requested a review from jmencak January 28, 2020 16:31
@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 28, 2020
jmencak
jmencak approved these changes Jan 28, 2020
View reviewed changes
Copy link
Contributor

@jmencak jmencak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 28, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmencak, sjug

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jmencak
Copy link
Contributor

jmencak commented Mar 9, 2020

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Mar 9, 2020
@openshift-ci-robot
Copy link
Contributor

@jmencak: This pull request references Bugzilla bug 1795671, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.2.z) matches configured target release for branch (4.2.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1795665 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1795665 targets the "4.3.z" release, matching the expected (4.3.z) release
  • bug has dependents

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

@sjug: This pull request references Bugzilla bug 1795671, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.2.z) matches configured target release for branch (4.2.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1795665 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1795665 targets the "4.3.z" release, matching the expected (4.3.z) release
  • bug has dependents

In response to this:

Bug 1795671: Do not set owner references on tuned ServiceAccount (4.2)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sdodson sdodson added priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. labels Mar 10, 2020
@openshift-merge-robot openshift-merge-robot merged commit f135787 into openshift:release-4.2 Mar 12, 2020
@openshift-ci-robot
Copy link
Contributor

@sjug: All pull requests linked via external trackers have merged. Bugzilla bug 1795671 has been moved to the MODIFIED state.

In response to this:

Bug 1795671: Do not set owner references on tuned ServiceAccount (4.2)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmencak jmencak jmencak approved these changes

Assignees

@jmencak jmencak

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sjug @openshift-ci-robot @jmencak @sdodson @openshift-merge-robot