Use Ignition 3 for MachineConfigs. #147
Conversation
MCO in OCP 4.6 will use Ignition 3 by default. Follow the same path.
openshift-ci-robot
added
the
approved
|
/test e2e-aws |
There was a problem hiding this comment.
the patch changes the Ignition import from github.com/coreos/ignition/config/v2_2/types to github.com/coreos/ignition/v2/config/v3_1/types, with the side effect that the 'ignition types configuration' needs to be passed raw (json) instead of a igntypes.Config object. Looks safe to me, the marshalization indeed should never fail.
The rest of the modifications is side effects of the package import updates.
Thanks for the PR Jiri
|
Thank you Kevin, much appreciated. Any chance of a lgtm label if you feel this is OK? |
|
/lgtm |
|
Don't think bot picks up edits. But thanks! /lgtm |
|
@jmencak: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Nice, it used to be possible to /lgtm own PRs. Good to know! |
|
/lgtm I'm always bad with these IRC-like messages :# :# :# ;-) and I think I already approved the PR when I validated my review:
but we'll see if this lgtm changes something or not |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jmencak, kpouget The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
It does, many thanks! Time to pray for CI tests to pass again. |
great, so "lgtm" and "approved" tags are not the same, I'll know it for next time :) |
They're not and only folk listed as approvers can add an "approved" label to a PR. |
|
/test e2e-aws |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
9 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
13 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
MCO in OCP 4.6 will use Ignition 3 by default. Follow the same path.