Bug 1879854: Bump vendor dependencies to k8s 1.19.0 #154
Conversation
Changes:
- vendor dependencies to k8s 1.19.0
- latest OpenShift and MCO dependencies
- switch to golang 1.15
- switched to controller-gen to generate/update CRDs; there is
no longer a need to manually edit CRDs after they are generated
openshift-ci-robot
added
the
approved
There was a problem hiding this comment.
Most of the changes look sane and match the comments in the commit message,
just for manifests/02-crd-profile.yaml, manifests/02-crd-tuned.yaml, could you confirm that the changes (paragraph filling and order of properties) come from the change of the tool used to generate it?
Thanks for the review, much appreciated! Yes, they come from the tool. That was actually the point to have this fully automated. I've also checked that the yamls semantically match. |
jmencak
changed the title
openshift-ci-robot
added
bugzilla/severity-high
|
@jmencak: This pull request references Bugzilla bug 1879854, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test e2e-aws-upgrade |
|
/test e2e-aws |
|
/joke |
|
@jmencak: Past, present, and future walked into a bar.... It was tense. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test e2e-aws-upgrade |
|
/test e2e-aws |
|
/lgtm |
|
/uncc @dagrayvid |
|
@jmencak: I thought my wife was joking when she said she'd leave me if I didn't stop signing "I'm A Believer"... Then I saw her face. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/test e2e-aws |
1 similar comment
|
/test e2e-aws |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/test e2e-aws |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
All checks succeeded. A way to generate CRD automatically by approved binaries will be done in a follow-up PR. |
|
@sttts's concern with the YAML file has been addressed AFAIU, and his concern with the CRD generator will be addressed in a follow-up PR, so I think all the concern are resolved. /lgtm thanks Jiri |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jmencak, kpouget The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Sgtm. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@jmencak: All pull requests linked via external trackers have merged: Bugzilla bug 1879854 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Changes:
no longer a need to manually edit CRDs after they are generated